[Minor] Correct Compose sample config #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jranson
approved these changes
Jan 29, 2021
There was a problem hiding this comment.
Thanks so much for coming across these and submitting the patches. Much appreciated, and sorry that my tired eyes did not catch them when we published first the docker compose! The provider -> origin_type is good for now, since the docker-compose is still based on the 1.1 codebase, so I appreciate that as well. Once we move the docker-compose to a 2.0 build, I will change them back for compatibility.
|
btw, @ntk148v if you would not mind signing the Contributor License Agreement, which just ensures that you acknowledge you are donating this contribution to a Comcast-sponsored project, the system will allow me to merge it. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.