Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI to GitHub Actions #583

Merged
merged 1 commit into from
May 2, 2020
Merged

Migrate CI to GitHub Actions #583

merged 1 commit into from
May 2, 2020

Conversation

seanpdoyle
Copy link
Contributor

@seanpdoyle seanpdoyle commented May 1, 2020

Migrate CI to GitHub Actions

GitHub Actions platform is free for open-source projects, and might
be more straightforward to configure as our Continuous Integration
provider than our current provider (TravisCI).

In an effort to solve the underlying issues at-play in PR#578, this
commit take similar measures:

  • depend on the webdrivers gem to manage Selenium and
    Chromedriver integration

  • install and configure NodeJS, the EmberCLI package, and the Dummy
    application's dependencies in CI

  • replace the usage of Appraisals with a more straightforward
    environment variable configuration for Rails versions (inspired by the
    scenic_views/scenic project's GitHub Actions configuration

  • install dependencies for Rails 4.2 through 5.2 with
    [email protected]

Test suite changes

In the interest of returning our continuous integration into a reliably
passing state, this commit configures the tests covering the
include_ember_script_tags and include_ember_stylesheet_tags. Once
we're re-established a passing baseline and can confidently resume
accepting open-source contributions, we can investigate what has changed
in EmberCLI to break those tests. Until then, we'll skip them so that
they don't hold us up.

Gemfile Show resolved Hide resolved
@seanpdoyle seanpdoyle force-pushed the github-actions-ci branch 16 times, most recently from c479a82 to c225112 Compare May 2, 2020 01:30
[GitHub Actions][] platform is free for open-source projects, and might
be more straightforward to configure as our Continuous Integration
provider than our current provider ([TravisCI][]).

In an effort to solve the underlying issues at-play in [PR#578][], this
commit take similar measures:

* depend on the [`webdrivers` gem][webdrivers] to manage Selenium and
  Chromedriver integration

* install and configure NodeJS, the EmberCLI package, and the Dummy
  application's dependencies in CI

* replace the usage of Appraisals with a more straightforward
  environment variable configuration for Rails versions (inspired by the
  [`scenic_views/scenic` project's][scenic] GitHub Actions configuration

* install dependencies for Rails `4.2` through `5.2` with
  `[email protected]`

Test suite changes
---

In the interest of returning our continuous integration into a reliably
passing state, this commit configures the tests covering the
`include_ember_script_tags` and `include_ember_stylesheet_tags`. Once
we're re-established a passing baseline and can confidently resume
accepting open-source contributions, we can investigate what has changed
in EmberCLI to break those tests. Until then, we'll skip them so that
they don't hold us up.

[GitHub Actions]: https://help.github.com/en/actions/building-and-testing-code-with-continuous-integration/about-continuous-integration
[TravisCI]: https://travis-ci.org/
[PR#578]: #578
[webdrivers]: https://github.com/titusfortner/webdrivers/tree/v3.0.0
[scenic]: https://github.com/scenic-views/scenic/blob/7898354b471aa3f7c0011d1b7775fe88035ed30c/.github/workflows/ci.yml
@seanpdoyle seanpdoyle merged commit e0fb13c into master May 2, 2020
@seanpdoyle seanpdoyle deleted the github-actions-ci branch May 2, 2020 15:01
@tricknotes tricknotes mentioned this pull request Feb 18, 2024
seanpdoyle pushed a commit that referenced this pull request Feb 18, 2024
This test has been skipped since #583.

Currently, it passes when executed. This commit re-enables the test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant