Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Malformed version number string ^1.13.12 #262

Closed
zacstewart opened this issue Nov 13, 2015 · 3 comments
Closed

Malformed version number string ^1.13.12 #262

zacstewart opened this issue Nov 13, 2015 · 3 comments
Labels
bug

Comments

@zacstewart
Copy link
Contributor

Looks like using Gem::Version to match version numbers of Node packages isn't going to work very well. Node uses different version formats than ruby Gems, e.g. carets instead of ~>

ArgumentError:
  Malformed version number string ^1.13.12
# /home/rof/cache/bundler/ruby/2.2.0/gems/ember-cli-rails-0.4.0/lib/ember-cli/helpers.rb:6:in `match_version?'
# /home/rof/cache/bundler/ruby/2.2.0/gems/ember-cli-rails-0.4.0/lib/ember-cli/app.rb:205:in `check_ember_cli_version!'
# /home/rof/cache/bundler/ruby/2.2.0/gems/ember-cli-rails-0.4.0/lib/ember-cli/app.rb:194:in `prepare'
# /home/rof/cache/bundler/ruby/2.2.0/gems/ember-cli-rails-0.4.0/lib/ember-cli/app.rb:23:in `compile'
# /home/rof/cache/bundler/ruby/2.2.0/gems/ember-cli-rails-0.4.0/lib/ember-cli/runner.rb:46:in `compile!'
# /home/rof/cache/bundler/ruby/2.2.0/gems/ember-cli-rails-0.4.0/lib/ember-cli/runner.rb:17:in `process'
# /home/rof/cache/bundler/ruby/2.2.0/gems/ember-cli-rails-0.4.0/lib/ember-cli-rails.rb:62:in `block in process_path'
# /home/rof/cache/bundler/ruby/2.2.0/gems/ember-cli-rails-0.4.0/lib/ember-cli-rails.rb:86:in `block in each_app'
# /home/rof/cache/bundler/ruby/2.2.0/gems/ember-cli-rails-0.4.0/lib/ember-cli-rails.rb:86:in `each'
# /home/rof/cache/bundler/ruby/2.2.0/gems/ember-cli-rails-0.4.0/lib/ember-cli-rails.rb:86:in `each_app'
# /home/rof/cache/bundler/ruby/2.2.0/gems/ember-cli-rails-0.4.0/lib/ember-cli-rails.rb:62:in `process_path'
# /home/rof/cache/bundler/ruby/2.2.0/gems/ember-cli-rails-0.4.0/lib/ember-cli/middleware.rb:13:in `call'
# /home/rof/cache/bundler/ruby/2.2.0/gems/warden-1.2.3/lib/warden/manager.rb:35:in `block in call'
# /home/rof/cache/bundler/ruby/2.2.0/gems/warden-1.2.3/lib/warden/manager.rb:34:in `catch'
# /home/rof/cache/bundler/ruby/2.2.0/gems/warden-1.2.3/lib/warden/manager.rb:34:in `call'
# /home/rof/cache/bundler/ruby/2.2.0/gems/rack-1.6.4/lib/rack/etag.rb:24:in `call'
# /home/rof/cache/bundler/ruby/2.2.0/gems/rack-1.6.4/lib/rack/conditionalget.rb:38:in `call'
# /home/rof/cache/bundler/ruby/2.2.0/gems/rack-1.6.4/lib/rack/head.rb:13:in `call'
# /home/rof/cache/bundler/ruby/2.2.0/gems/remotipart-1.2.1/lib/remotipart/middleware.rb:27:in `call'
# /home/rof/cache/bundler/ruby/2.2.0/gems/rack-1.6.4/lib/rack/session/abstract/id.rb:225:in `context'
# /home/rof/cache/bundler/ruby/2.2.0/gems/rack-1.6.4/lib/rack/session/abstract/id.rb:220:in `call'
# /home/rof/cache/bundler/ruby/2.2.0/gems/web-console-2.2.1/lib/web_console/middleware.rb:39:in `call'
# /home/rof/cache/bundler/ruby/2.2.0/gems/railties-4.2.4/lib/rails/rack/logger.rb:38:in `call_app'
# /home/rof/cache/bundler/ruby/2.2.0/gems/railties-4.2.4/lib/rails/rack/logger.rb:20:in `block in call'
# /home/rof/cache/bundler/ruby/2.2.0/gems/railties-4.2.4/lib/rails/rack/logger.rb:20:in `call'
# /home/rof/cache/bundler/ruby/2.2.0/gems/rack-1.6.4/lib/rack/methodoverride.rb:22:in `call'
# /home/rof/cache/bundler/ruby/2.2.0/gems/rack-1.6.4/lib/rack/runtime.rb:18:in `call'
# /home/rof/cache/bundler/ruby/2.2.0/gems/rack-1.6.4/lib/rack/lock.rb:17:in `call'
# /home/rof/cache/bundler/ruby/2.2.0/gems/rack-1.6.4/lib/rack/sendfile.rb:113:in `call'
# /home/rof/cache/bundler/ruby/2.2.0/gems/railties-4.2.4/lib/rails/engine.rb:518:in `call'
# /home/rof/cache/bundler/ruby/2.2.0/gems/railties-4.2.4/lib/rails/application.rb:165:in `call'
# /home/rof/cache/bundler/ruby/2.2.0/gems/rack-test-0.6.3/lib/rack/mock_session.rb:30:in `request'
# /home/rof/cache/bundler/ruby/2.2.0/gems/rack-test-0.6.3/lib/rack/test.rb:244:in `process_request'
# /home/rof/cache/bundler/ruby/2.2.0/gems/rack-test-0.6.3/lib/rack/test.rb:124:in `request'
@seanpdoyle
Copy link
Contributor

@zacstewart thanks for bringing this to our attention.

Unfortunately, you're right, our current approach isn't the best.

Could you elaborate on why you're using ^ instead of ~>?

As a quick fix, would you be able to peg EmberCLI to a particular version, or change the ^ to ~>?

@seanpdoyle seanpdoyle added the bug label Nov 13, 2015
seanpdoyle added a commit that referenced this issue Nov 14, 2015
@seanpdoyle
No longer check dependencies
44ae262 
Closes [#262].

Managing user dependencies within app code is more trouble than it's
worth. Being explicit about our EmberCLI support in our `README.md` and
keeping the addon version in lock-step with the gem will be a better
solution long term.

Since EmberCLI now [writes to STDERR][stderr], which EmberCLI-Rails
[pipes to a file and monitors][error-file], front-end failures will
communicated to users through normal Error-raising means.

[#262]: #262
[stderr]: ember-cli/ember-cli#5039
[error-file]: #245
@seanpdoyle seanpdoyle mentioned this issue Nov 14, 2015
Merged
seanpdoyle added a commit that referenced this issue Nov 14, 2015
@seanpdoyle
No longer check dependencies
d98c9c4 
Closes [#262].

Managing user dependencies within app code is more trouble than it's
worth. Being explicit about our EmberCLI support in our `README.md` and
keeping the addon version in lock-step with the gem will be a better
solution long term.

Since EmberCLI now [writes to STDERR][stderr], which EmberCLI-Rails
[pipes to a file and monitors][error-file], front-end failures will
communicated to users through normal Error-raising means.

[#262]: #262
[stderr]: ember-cli/ember-cli#5039
[error-file]: #245
seanpdoyle added a commit that referenced this issue Nov 14, 2015
@seanpdoyle
No longer check dependencies
f31fee6 
Closes [#262].

Managing user dependencies within app code is more trouble than it's
worth. Being explicit about our EmberCLI support in our `README.md` and
keeping the addon version in lock-step with the gem will be a better
solution long term.

Since EmberCLI now [writes to STDERR][stderr], which EmberCLI-Rails
[pipes to a file and monitors][error-file], front-end failures will
communicated to users through normal Error-raising means.

[#262]: #262
[stderr]: ember-cli/ember-cli#5039
[error-file]: #245
seanpdoyle added a commit that referenced this issue Nov 14, 2015
@seanpdoyle
No longer check dependencies
3d2af74 
Closes [#262].

Managing user dependencies within app code is more trouble than it's
worth. Being explicit about our EmberCLI support in our `README.md` and
keeping the addon version in lock-step with the gem will be a better
solution long term.

Since EmberCLI now [writes to STDERR][stderr], which EmberCLI-Rails
[pipes to a file and monitors][error-file], front-end failures will
communicated to users through normal Error-raising means.

[#262]: #262
[stderr]: ember-cli/ember-cli#5039
[error-file]: #245
seanpdoyle added a commit that referenced this issue Nov 14, 2015
@seanpdoyle
No longer check dependencies
b8a8452 
Closes [#262].

Managing user dependencies within app code is more trouble than it's
worth. Being explicit about our EmberCLI support in our `README.md` and
keeping the addon version in lock-step with the gem will be a better
solution long term.

Since EmberCLI now [writes to STDERR][stderr], which EmberCLI-Rails
[pipes to a file and monitors][error-file], front-end failures will
communicated to users through normal Error-raising means.

[#262]: #262
[stderr]: ember-cli/ember-cli#5039
[error-file]: #245
@zacstewart
Copy link
Contributor Author

Thanks for the quick response!

@seanpdoyle
Copy link
Contributor

@zacstewart glad we could help resolve the issue!

Unfortunately, the fix will probably sit in master for a few more days.

The next release will be a minor version bump that will introduce some breaking changes (it's all for the best, I promise!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zacstewart @seanpdoyle