Skip to content

chore(suite): add Holesky#9898

Merged
tomasklim merged 2 commits intodevelopfrom
feat/replace-goerli-with-holesky
Dec 5, 2023
Merged

chore(suite): add Holesky#9898
tomasklim merged 2 commits intodevelopfrom
feat/replace-goerli-with-holesky

Conversation

@AdamSchinzel
Copy link
Contributor

@AdamSchinzel AdamSchinzel commented Nov 9, 2023 •
edited
Loading

Description

Added Holesky as a new testnet.

Also unified some config for ETH coins because there were some failing tests and it would be better to have it the same for every coin.

@PeKne
Copy link
Contributor

PeKne commented Nov 10, 2023

Just thinking out loud... What happens if the user has some remembered Goerli account and upgrades to the new suite version that does not support it anymore? Could not it lead to accessing some undefined property, since Goerli was removed from the networksConfig.ts?

@AdamSchinzel
Copy link
Contributor Author

AdamSchinzel commented Nov 10, 2023

Just thinking out loud... What happens if the user has some remembered Goerli account and upgrades to the new suite version that does not support it anymore? Could not it lead to accessing some undefined property, since Goerli was removed from the networksConfig.ts?

Yes, I forgot to add migrations, thanks for reminding me. I was not testing it at all yet since it can't work because Holesky is not in blockbook.

@AdamSchinzel AdamSchinzel changed the title chore(suite): replace Goerli with Holesky chore(suite): add Holesky Nov 14, 2023
@AdamSchinzel AdamSchinzel mentioned this pull request Nov 28, 2023
Closed
@AdamSchinzel AdamSchinzel force-pushed the feat/replace-goerli-with-holesky branch from 5f05231 to d30ca88 Compare December 5, 2023 08:11
@AdamSchinzel AdamSchinzel force-pushed the feat/replace-goerli-with-holesky branch from d30ca88 to 5ee45c4 Compare December 5, 2023 08:15
@komret komret added the release Will be included in the upcoming release. Needs to be backported to the release branch. label Dec 5, 2023
@tomasklim tomasklim merged commit 8776bb7 into develop Dec 5, 2023
@tomasklim tomasklim deleted the feat/replace-goerli-with-holesky branch December 5, 2023 15:12
@bosomt
Copy link
Contributor

bosomt commented Dec 7, 2023

QA OK

https://holesky1.trezor.io/tx/0xd2d9c358446a539cdb24fa3c948fb373c976f33cd16c0af15aade3ee7e7a9acf

Info:

  • Suite version: desktop 23.12.1 (9ec6ac5438d7a952abcbbdc049bf729a47d4e039)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/23.12.1 Chrome/118.0.5993.129 Electron/27.0.4 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2B1 2.6.4 regular (revision 1f693d3561c375661563970e066f678590abc19c)
  • Transport: BridgeTransport 2.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomasklim tomasklim tomasklim approved these changes

@alex-jerechinsky alex-jerechinsky Awaiting requested review from alex-jerechinsky

@marekrjpolak marekrjpolak Awaiting requested review from marekrjpolak marekrjpolak is a code owner

@matejkriz matejkriz Awaiting requested review from matejkriz

@mroz22 mroz22 Awaiting requested review from mroz22 mroz22 is a code owner

@szymonlesisz szymonlesisz Awaiting requested review from szymonlesisz szymonlesisz is a code owner

@dahaca dahaca Awaiting requested review from dahaca

Assignees

No one assigned

Labels

release Will be included in the upcoming release. Needs to be backported to the release branch.

Projects

Suite
Archived in project
Suite Pull Requests
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AdamSchinzel @PeKne @bosomt @tomasklim @komret