chore(connect): move remembered device away from local variable

[mroz22]

Make "remember" device work when core is loaded in popup.

Description

In #9525 we are introducing loading connect core inside popup. This has 2 effects:

• to support environments that can't inject iframe.
• to support webusb in popup

Couple of changes are needed. First of them is how "remember" device works:

• Previously, remembered device was stored in a local variable which was ok, because iframe was actually making it persist between 2 calls. This is not the case anymore. When core is loaded in popup, everything locally stored is gone after popup is closed. This means we need to move it to storage.
• Previously, due to persistent nature ensured by iframe, when user disconnected device when popup was already closed, transport event was handled and local variable _preferedDevice was cleared. Without this behaviour we would get Device not found error, because connect would obviously try to target a device which is not connected at all. I had to change this behaviour in 2 ways:
  • do not rely on disconnect event
  • remove prefered device from store when device is not available in initDevice phase and show device selection instead.

Testing

• it should be just rework of internal logic, now new features, no changes
• mainly using webusb with remember on sldev should work as you would expect
• maybe try please testing with more than 1 device

Related Issue

#9525, #9644

Screenshots:

Connecting device for the 1st time or if there is more than 1 device connected

[socket-security]

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

[mroz22]

check removed line 297, its related

[mroz22]

cc @marekrjpolak because I am touching core (_preferredDevice), cc @karliatto because it relates to all kind of popup behaviours and is related to webextension

[mroz22]

if possible and we are sure it doesn't break anything, it would make sense to include this in 9.1.12 release. since properly worker @trezor/connect-webextension sort of depends on this imho. cc @karliatto

[martykan]

/rebase

[github-actions]

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/7714064439

[martykan]

@mroz22 For some reason remember device doesn't seem to get saved on the first try, but only the second time. Will debug more tomorrow

[martykan]

tmp: run all popup test should be included or probably not?

Update: removed it

[mroz22]

I am still not decided whether to push this into 9.1.12 or wait for 9.1.13. leaning slightly towards 9.1.13

[Hannsek]

If we don't need it in the next release and you are unsure, let's wait.

[mroz22]

/rebase

[github-actions]

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/7773140543