Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(suite): mark potentially phishy zero-value transactions #7391

Merged
merged 1 commit into from
Jan 20, 2023
Merged

feat(suite): mark potentially phishy zero-value transactions #7391

merged 1 commit into from
Jan 20, 2023

Conversation

dahaca
Copy link
Contributor

@dahaca dahaca commented Jan 16, 2023

Description

  • mark potentially phishy zero-value transactions

Related Issue

Resolve #7278

Screenshots:

image

image

@dahaca dahaca requested review from sime and tomasklim January 16, 2023 00:04
komret
komret approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@komret komret left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine, but I have some doubts regarding the logic for marking transactions as discussed in #7278, @Hannsek.

@dahaca dahaca merged commit d8b77aa into develop Jan 20, 2023
@dahaca dahaca deleted the feat/zero-phishing branch January 20, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komret komret komret approved these changes

@sime sime Awaiting requested review from sime

@tomasklim tomasklim Awaiting requested review from tomasklim

@alex-jerechinsky alex-jerechinsky Awaiting requested review from alex-jerechinsky

@marekrjpolak marekrjpolak Awaiting requested review from marekrjpolak marekrjpolak is a code owner

@matejkriz matejkriz Awaiting requested review from matejkriz

Assignees

@komret komret

@Hannsek Hannsek

Labels
Roadmap: Off
Projects
No open projects
Suite Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address poisoning attack: Label zero value transactions in TX detail
4 participants
@dahaca @komret @tsusanka @Hannsek