Conversation
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Greptile OverviewGreptile SummaryFoundation dependencies updated across 34 package.json files with major bumps to electron 40.1.0,
Minor/patch updates include Sentry packages (10.38.0), Babel (7.28.6), prettier (3.8.1), webpack tooling, nx, and react-native packages. All resolutions properly aligned in yarn.lock.
|
| Filename | Overview |
|---|---|
| package.json | Updated resolutions for electron 40.1.0, prettier 3.8.1, sentry 10.38.0, and babel 7.28.6 - standard dependency bumps |
| packages/eslint/package.json | Bumped @eslint/js to 10.0.0, globals to 17.2.0, typescript-eslint to 8.54.0, eslint-plugin-jest to 29.12.1 - no breaking changes affecting codebase |
| packages/suite-desktop/package.json | Updated electron to 40.1.0 and electron-builder to 26.6.0 - no clipboard renderer usage detected |
| packages/suite-build/package.json | Updated webpack-related packages: html-webpack-plugin 5.6.6, webpack-bundle-analyzer 5.2.0, @sentry/webpack-plugin 4.8.0 - minor updates |
| packages/suite-desktop-core/package.json | Updated @sentry/electron to 7.7.1, @sentry/webpack-plugin to 4.8.0, electron to 40.1.0 |
| suite-native/storage/package.json | Updated react-native-mmkv to 4.1.2 and @sentry/react-native to 7.11.0 |
| yarn.lock | Lockfile updated with all dependency resolutions - 1110 additions, 1037 deletions |
Last reviewed commit: 0d63b16
|
I rerun all tests, let's see if it helps. But that was a lot of failures... |
0d63b16 to
933bbb9
Compare
|
I force pushed to solve git conflict, let's see the CI now. If it still fails, needs investigation. EDIT: all green ✔️ |
Lemonexe
left a comment
There was a problem hiding this comment.
LGTM. Thank you very much for thorough maintenance work 👍
We still have to sort through the socket.dev warning, but that blocks merging so I'm approving ✔️
| }, | ||
| "devDependencies": { | ||
| "@eslint/js": "^9.39.2", | ||
| "@eslint/js": "^10.0.0", |
There was a problem hiding this comment.
I was a bit worried how would it work when you have mismatched major versions of @eslint/js and eslint. But no CI failure → seems alright ✔️
Well, false positive is only one possible bug, there is also false negative → I tested locally if eslint still catches, and it does ✔️
There was a problem hiding this comment.
Ok, but now I see in Socket.dev report that @eslint/js@10.0.0 is deprecated ❌
There is 10.0.1 but it's 10 days old, does not pass age gate.
I'm gonna edit this (revert to 9.39.2 which is the latest 9.x.x)
We'll bump both @eslint/js and eslint next month 🙂
I amended 7116463
|
@SocketSecurity ignore npm/@babel/core@7.28.6 @SocketSecurity ignore npm/nx@22.4.3 @SocketSecurity ignore npm/@sentry/browser@10.37.0 @SocketSecurity ignore npm/@typescript-eslint/eslint-plugin@8.54.0 @sentry-internal/replay-canvas @SocketSecurity ignore npm/core-js@3.48.0 |
933bbb9 to
c4ae667
Compare
|
✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found. |
|
✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found. |
|
@SocketSecurity ignore npm/@sentry/browser@10.36.0 |
Description
Update most Foundation-related dependencies.
major version:
@eslint/js: Quite a few, but since it's only linting, tests should cover that.globals: Only breaking change concerns someaudioWorkletvariables, and search fot them shows nothing suspicious.electron: Following breaking changes.tar.xzinstead of.zipon mac — It's only debug symbols, so it should be fine.minor version:
typescript-eslinteslint-plugin-jestcore-jsprettier@sentry/browser,@sentry/core,@sentry/electron,@sentry/react,@sentry/node,@sentry/node-core,@sentry/react,@sentry/react-native,@sentry/type,@sentry/webpack-pluginelectron-buildernxreact-native-mmkvreact-native-nitro-moduleswebpack-bundle-analyzerpatch version:
@babel/cli,@babel/core,@babel/node,@babel/plugin-proposal-decorators,@babel/preset-env,@babel/runtimesort-package-jsonhtml-webpack-plugin@braintree/sanitize-urlnot updated:
evolu&expo-sqlite: WIPset.prototype.intersection: Needed by evolu for nowcors: We should be able to get rid of it after evoluℹ️ For reference, last bump foundation deps PR was #24168
Notes for QA
Areas to test:
Related Issue
Resolve #24411
🔍🖥️ Suite desktop test results: View in Currents
🔍🖥️ Suite web test results: View in Currents
🔍🖥️ Suite native android test results: View in Currents