Merged
Conversation
Lemonexe
added
dependencies
Contributor
Author
|
Will merge, the Suite Web E2E tests are confirmed broken |
peter-sanderson
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ℹ️ I've developed this rebased on #23118, so even though that one isn't merged yet, this PR honors the age gate ✔️
eslintnow has stricter TS validation on configs, so I added JSDoc types to the eslint config files.Lot of new rules introduced in
eslint-plugin-react-hooks@7:react-hooks/immutabilityis good 👍 but it crashes on recursive calls, probably a bug in the plugin? It's just three cases, so I put an ignore there rather than disable this rule globally because of those false positivesRelated Issue
Part of #22351