chore(suite-desktop-core): bump @electron/fuses#20722
Merged
Conversation
Lemonexe
commented
Aug 13, 2025
| "main": "src/app.ts", | ||
| "scripts": { | ||
| "build:scripts": "yarn g:rimraf ./lib && yarn g:tsc --build tsconfig.scripts.json && find ./lib -name '*.js' -exec bash -c 'mv \"$0\" \"${0%.js}.mjs\"' {} \\;", | ||
| "build:scripts": "yarn g:rimraf ./lib && yarn g:tsc --build scripts/tsconfig.json && node scripts/rename-js-to-mjs.cjs", |
Contributor
Author
There was a problem hiding this comment.
We have many simple bash scripts in-lined in package.json, that's why "git bash for windows" is the only supported shell for native windows dev env.
But find binary is not available in git bash for windows, so this was not working (files were not renamed, and then not found, and build crashed)
Lemonexe
commented
Aug 13, 2025
| "build:scripts": "yarn g:rimraf ./lib && yarn g:tsc --build scripts/tsconfig.json && node scripts/rename-js-to-mjs.cjs", | ||
| "build:core": "yarn g:rimraf dist && TS_NODE_PROJECT=\"tsconfig.json\" yarn webpack --config ./webpack/core.webpack.config.ts", | ||
| "type-check": "yarn g:tsc --build tsconfig.json", | ||
| "type-check": "yarn g:tsc --build tsconfig.json && yarn g:tsc --build scripts/tsconfig.json", |
Contributor
Author
There was a problem hiding this comment.
Before this PR, the scripts folder was targeted by both tsconfig.scripts.json (for building) and tsconfig.json (for type-checking).
This is not possible now because of the different "module" and "moduleResolution", so everything related to scripts must be handled by their own tsconfig.
Lemonexe
added
the
no-project
peter-sanderson
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@electron/fusesI tested linux build & native windows build.
Related Issue
Followup to #20107
🔍🖥️ Suite desktop test results: View in Currents
🔍🖥️ Suite web test results: View in Currents