Skip to content

chore(suite-desktop): downgrade electron-builder#18920

Merged
Lemonexe merged 1 commit intodevelopfrom
chore/downgrade-electron-builder
May 14, 2025
Merged

chore(suite-desktop): downgrade electron-builder#18920
Lemonexe merged 1 commit intodevelopfrom
chore/downgrade-electron-builder

Conversation

@Lemonexe
Copy link
Copy Markdown
Contributor

@Lemonexe Lemonexe commented May 13, 2025

Description

Partial revert of #18819: downgrade electron-builder, as it broke macOS dev build.

Multiple problems there, described in issue #18919

🔍🖥️ Suite web test results: View in Currents

🔍🖥️ Suite desktop test results: View in Currents

@Lemonexe Lemonexe added dependencies Pull requests that update a dependency file build-desktop This will trigger the build of desktop apps for your PR no-project This label is used to specify that PR doesn't need to be added to a project labels May 13, 2025
@Lemonexe Lemonexe marked this pull request as ready for review May 13, 2025 14:30
@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 13, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

  • builder-util-runtime@9.3.1
  • @electron/osx-sign@1.3.1
  • @electron/asar@3.2.18
  • @electron/rebuild@3.7.0
  • builder-util@26.0.1
  • electron-publish@26.0.1
  • @electron/universal@2.0.1
  • app-builder-lib@26.0.3
  • electron-builder@26.0.3
  • dmg-builder@26.0.3
  • electron-builder-squirrel-windows@26.0.3

View full report

@Lemonexe
Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore-all
all those libs are electron-builder, we're reverting to previously used version.

@Lemonexe
Copy link
Copy Markdown
Contributor Author

Will merge despite failing Desktop E2E tests + one Web test (Slack)

@vojtatranta
Copy link
Copy Markdown
Contributor

Okay, os when I set here identity: '-', I CAN run the ARM build and x64 builds from local.

Yeah, and I can run it even without identity: '-'

Which is pretty good.

@Lemonexe
Copy link
Copy Markdown
Contributor Author

Yeah, and I can run it even without identity: '-'

I'd expect that, because that's tried & true with this electron-builder 26.0.3 , but thanks for confirming!

Okay, os when I set here identity: '-', I CAN run the ARM build and x64 builds from local.

Good to know! This means devs can run directly ARM builds without need for x64 on rosetta.

@Lemonexe Lemonexe merged commit 1964fd3 into develop May 14, 2025
73 of 83 checks passed
@Lemonexe Lemonexe deleted the chore/downgrade-electron-builder branch May 14, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-desktop This will trigger the build of desktop apps for your PR dependencies Pull requests that update a dependency file no-project This label is used to specify that PR doesn't need to be added to a project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants