Skip to content

fix(suite-desktop): macOS ARM build adhoc signing#18906

Closed
Lemonexe wants to merge 1 commit intodevelopfrom
fix/macos-arm-adhoc-signing
Closed

fix(suite-desktop): macOS ARM build adhoc signing#18906
Lemonexe wants to merge 1 commit intodevelopfrom
fix/macos-arm-adhoc-signing

Conversation

@Lemonexe
Copy link
Copy Markdown
Contributor

@Lemonexe Lemonexe commented May 13, 2025

Description

Followup to #18819, which broke CI dev desktop build for macOS 🍎

With electron-builder 26.0.13 a change was done in #9007:

  • if identity ENV is missing (as in dev builds) ARM builds are now adhoc signed by default
  • that crashes in CI
  • so explicitly skip signing when not codesign build

🔍🖥️ Suite desktop test results: View in Currents

@Lemonexe Lemonexe added ci Continuous Integration (CI) related build-desktop This will trigger the build of desktop apps for your PR no-project This label is used to specify that PR doesn't need to be added to a project labels May 13, 2025
@Lemonexe Lemonexe marked this pull request as ready for review May 13, 2025 11:29
@Lemonexe Lemonexe requested a review from komret as a code owner May 13, 2025 11:29
@vojtatranta
Copy link
Copy Markdown
Contributor

I think there is a problem:

  • for some reason, there isn't an icon of the Trezor Suite app, but it was in the previous version of the electron-builder
  • now, x64 build WON'T be started on Mac but it WAS possible to be started on the previous version of the electron builder, but it was likely because I made a build with identity: '-' which triggered ad-hoc signing

@vojtatranta
Copy link
Copy Markdown
Contributor

And local build x64 won't start at all with error: https://pastebin.com/u6GgqPSU

@Lemonexe Lemonexe closed this May 13, 2025
@Lemonexe Lemonexe mentioned this pull request May 13, 2025
@Lemonexe Lemonexe deleted the fix/macos-arm-adhoc-signing branch May 13, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-desktop This will trigger the build of desktop apps for your PR ci Continuous Integration (CI) related no-project This label is used to specify that PR doesn't need to be added to a project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants