chore: bump react-hook-form, @hookform/resolvers, yup #18704
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| import { useEffect, useRef } from 'react'; | ||
| import { useDispatch, useSelector } from 'react-redux'; | ||
|
|
||
| import { BuyTrade, CryptoId, FiatCurrencyCode } from 'invity-api'; | ||
|
|
||
| import { useFormatters } from '@suite-common/formatters'; | ||
| import { | ||
|
|
@@ -34,53 +34,58 @@ const useReceiveAccountChangeEffect = ({ setValue }: TradingBuyForm) => { | |
| }, [selectedReceiveAccount, setValue]); | ||
| }; | ||
|
|
||
| const useAmountAndCurrencyFieldsChangeEffect = ({ setValue, getValues, watch }: TradingBuyForm) => { | ||
| const dispatch = useDispatch(); | ||
| const prevCryptoId = useRef<CryptoId | undefined>(undefined); | ||
|
Contributor
Author
There was a problem hiding this comment. using cryptoId I can distinguish tokens of the same network and solve #18677 (review) |
||
| const prevFiatCurrency = useRef<FiatCurrencyCode | undefined>(getValues('fiatCurrency')); | ||
|
|
||
| useEffect(() => { | ||
| const { unsubscribe } = watch( | ||
| ({ focusedValue, asset, amountInCrypto, fiatCurrency }, { name, type }) => { | ||
| switch (name) { | ||
| case 'fiatValue': | ||
| if (focusedValue === 'fiatValue' && type === 'change') { | ||
| setValue('cryptoValue', undefined, { shouldValidate: true }); | ||
| if (amountInCrypto) { | ||
| setValue('amountInCrypto', false); | ||
| } | ||
| } | ||
| break; | ||
|
|
||
| case 'cryptoValue': | ||
| if (focusedValue === 'cryptoValue' && type === 'change') { | ||
| setValue('fiatValue', undefined, { shouldValidate: true }); | ||
| if (!amountInCrypto) { | ||
| setValue('amountInCrypto', true); | ||
| } | ||
| } | ||
| break; | ||
|
|
||
| case 'fiatCurrency': | ||
| if (fiatCurrency !== prevFiatCurrency.current) { | ||
| prevFiatCurrency.current = fiatCurrency; | ||
| setValue('fiatValue', undefined, { shouldValidate: true }); | ||
| setValue('cryptoValue', undefined, { shouldValidate: true }); | ||
| } | ||
| break; | ||
|
|
||
| case 'asset': { | ||
| if (asset?.cryptoId !== prevCryptoId.current) { | ||
| prevCryptoId.current = asset?.cryptoId as CryptoId | undefined; | ||
| setValue('cryptoValue', undefined, { shouldValidate: true }); | ||
| dispatch( | ||
| setBuySelectedReceiveAccount({ selectedReceiveAccount: undefined }), | ||
| ); | ||
| } | ||
|
Contributor
Author
There was a problem hiding this comment. Only clear the This fixes an infinite render loop, that only manifested in Note: I spend considerably time debugging this, trying to find the real root cause why this started happening after bumping react-hook-form to 7.55. I did not succeed 😞
This issue sounds relevant, but I reproduced the same crash even in 7.55, not just 7.56 |
||
| break; | ||
| } | ||
|
|
||
| default: | ||
| // do nothing | ||
| break; | ||
| } | ||
| }, | ||
| ); | ||
|
|
||
| return unsubscribe; | ||
| }, [dispatch, setValue, watch]); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solve TS error at L76 (
string | undefinednot assignable tostringforpath, signature)The problem arose when bumping
@hookform/resolvers + react-hook-form, and then bumpingyupdid not help.It took me a while to realize that the former two are not at fault, it's
yupthat was insufficiently typed (in both versions I tried!), andreact-hook-formmerely tightened its types to catch that.