Conversation
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
6a8839e to
caf160a
Compare
|
✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found. |
|
✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found. |
80d0b32 to
fa16c46
Compare
|
@SocketSecurity ignore npm/@tybys/wasm-util@0.9.0 uses fetch to load async WASM modules and seems legit |
fa16c46 to
e8f16db
Compare
There was a problem hiding this comment.
Found out that side effects like thsi absolutely must be in its separate file.
I spent a while time debugging Suite Native app crashing during runtime because of infinite loop:
RangeError: Maximum call stack size exceeded
I didn't think this would be the cause, because test-utils are only used in tests.. The file mocks.ts is indirectly included in suite-native tests, but that shouldn't leak into runtime code!
It seems to me, that precisely that is happening. Just because mocks.ts is included in the suite-native packages, even though only in tests, its side effects are performed and leak into runtime code even though never referenced. Idk it's weird AF. Isolating the browser mocks into special file solves this 🙈
e8f16db to
abd0359
Compare
Description
Followup to #18323: update CI-related dependencies, some of them newly owned by @trezor/suite-foundation.
Not those used in runtime, I'm gonna update those after May freeze ❄️
major version:
nx(a ton of changes, but we only use a tiny fraction of what nx offers, and I didn't notice anything relevant to us)glob(breaking change is only node 20 → 22 ✅)sort-package-jsonfake-indexeddb(drops a polyfill that we now have to include)minor version:
fs-extraprettier@eslint/jseslinteslint-plugin-mdxtypescript-eslintpatch version:
eslint-plugin-reactnot updated:
chalk(v5 is ESM only, and some scripts that use it are still CJS)Bump deps that are related to CI and not runtime.
Only glob is used in build (webpack electron-main bundle), so I checked that part of build.
QA
👁️ Besides CI checks, I have tested locally:
🔍🖥️ Suite web test results: View in Currents
🔍🖥️ Suite desktop test results: View in Currents
🔍🖥️ Suite native android test results: View in Currents