Skip to content

feat(suite-desktop): force app update through stagingPercentage on manual action#18447

Merged
Lemonexe merged 2 commits intodevelopfrom
feat/force-desktop-update
Apr 17, 2025
Merged

feat(suite-desktop): force app update through stagingPercentage on manual action#18447
Lemonexe merged 2 commits intodevelopfrom
feat/force-desktop-update

Conversation

@Lemonexe
Copy link
Copy Markdown
Contributor

@Lemonexe Lemonexe commented Apr 17, 2025

Description

After electron-userland/electron-builder#9016 , bump electron-updater and use the new interface:

  • force app update through staging percentage rollout logic when it is checked manually
  • unless the stagingPercentage is exactly 0 (required here)

Related Issue

Resolve #11676

Screenshots:

With locally mocked latest,yml on a testing branch, using these instructions, this is how it behaves with different stagingPercentage:

stagingPercentage = 100, the download is offerred automatically (same as currently):
fully released with 100.webm

stagingPercentage = 1, so I am not within the rollout, but I can force the update by checking manually:
force update through 1.webm

stagingPercentage = 0, so the update is blocked (same as currently):
cant force update through 0.webm

🔍🖥️ Suite web test results: View in Currents

🔍🖥️ Suite desktop test results: View in Currents

@Lemonexe Lemonexe force-pushed the feat/force-desktop-update branch from b9cb542 to c070f90 Compare April 17, 2025 17:47
@trezor-ci
Copy link
Copy Markdown
Contributor

trezor-ci commented Apr 17, 2025

✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

@Lemonexe Lemonexe marked this pull request as ready for review April 17, 2025 17:55
@Lemonexe Lemonexe requested a review from komret as a code owner April 17, 2025 17:55
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2025

Walkthrough

The changes update the version of the "electron-updater" dependency from 6.6.2 to 6.6.3 in both the @trezor/suite-desktop-core and @trezor/suite-desktop package.json files. Additionally, within the auto-updater.ts module of @trezor/suite-desktop-core, the logic for determining rollout eligibility is modified. A wrapper is introduced around the autoUpdater.isUserWithinRollout method to adjust its behavior during manual update checks: if a manual check is performed and the rollout percentage is not zero, the method now returns true, bypassing the standard staged rollout restriction. For non-manual checks, the original rollout logic remains unchanged. No changes are made to exported or public entity declarations.

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c070f90 and a991e84.

📒 Files selected for processing (1)
  • packages/suite-desktop-core/src/modules/auto-updater.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/suite-desktop-core/src/modules/auto-updater.ts
⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: PR-check / node-authorizeCoinjoin cancelCoinjoinAuthorization passphrase unlockPath setBusy checkFirmwareAuthenticity keepSession cancel.test info.test resetDevice-api
  • GitHub Check: PR-check / node-override init-api-flaky
  • GitHub Check: PR-check / web-override init-api-flaky
  • GitHub Check: PR-check / web-authorizeCoinjoin cancelCoinjoinAuthorization passphrase unlockPath setBusy checkFirmwareAuthenticity keepSession cancel.test info.test resetDevice-api
  • GitHub Check: build-deploy
  • GitHub Check: build-deploy
  • GitHub Check: transport-e2e-test
  • GitHub Check: test
  • GitHub Check: Setup and Cache Dependencies
  • GitHub Check: Analyze with CodeQL (javascript)
  • GitHub Check: connect-web-e2e

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@komret komret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Comment thread packages/suite-desktop-core/src/modules/auto-updater.ts Outdated
@Lemonexe Lemonexe force-pushed the feat/force-desktop-update branch from c070f90 to a991e84 Compare April 17, 2025 18:16
@trezor-ci
Copy link
Copy Markdown
Contributor

✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

@Lemonexe Lemonexe merged commit cd033e8 into develop Apr 17, 2025
63 checks passed
@Lemonexe Lemonexe deleted the feat/force-desktop-update branch April 17, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Force auto-update option

3 participants