fix(suite-desktop-core): proper name & place for electron-builder hooks#17234
Merged
fix(suite-desktop-core): proper name & place for electron-builder hooks#17234
Conversation
0b7fc99 to
f5e8510
Compare
Lemonexe
commented
Feb 26, 2025
| "main": "src/app.ts", | ||
| "scripts": { | ||
| "build:lib": "yarn g:rimraf ./lib && yarn g:tsc --build tsconfig.lib.json", | ||
| "build:core": "yarn build:lib && yarn g:rimraf dist && TS_NODE_PROJECT=\"tsconfig.json\" yarn webpack --config ./webpack/core.webpack.config.ts", |
Contributor
Author
There was a problem hiding this comment.
❗ It was a mistake to include building electron-builder hooks in the build:core, because that's not related to electron-builder at all, it builds JS bundle for electron-main process 🤦
Instead, I moved build:scripts where it logically belongs - as first step of build:app:electron
Ofc it worked incidentally, because build:core gets called before build:app:electron
komret
approved these changes
Feb 26, 2025
This was referenced Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
suite-desktop-core/tsconfig.lib.json, becauseyarn update-project-referencesis unstable; produces diff that is not detected byyarn verify-project-references, so it passed CI when I merged it in #17056 😮yarn build:libis always used for building "the main source code" of the given package.suite-desktop-core/scripts/dirsrc/, they don't use any of the workspace importsbuild:lib→ rename tobuild:scriptsyarn update-project-references, which is correct, because it's a custom taskyarn build:scriptsfrom 5s to 15s on my PC 🐌 🐢 😴QA
Tested that desktop build works from scratch (all gitignored dirs deleted in
suite-desktop) ✔️Notes
The tsconfig.lib.json passed CI, because
yarn verify-project-referencesthrows only on tsconfig.json,but
yarn update-project-referencesmodifies also tsconfig.lib.json.The script is inconsistent,
yarn verify-project-referencesshould throw if there are any changes that would be modified byyarn update-project-references.That should be fixed, but outside of scope of this PR.
@coderabbitai ignore