Revert "feat(suite-desktop): turn on ASAR integrity check"#16972
Merged
peter-sanderson merged 1 commit intodevelopfrom Feb 13, 2025
Merged
Revert "feat(suite-desktop): turn on ASAR integrity check"#16972peter-sanderson merged 1 commit intodevelopfrom
peter-sanderson merged 1 commit intodevelopfrom
Conversation
This reverts commit 7282d84.
peter-sanderson
approved these changes
Feb 13, 2025
Contributor
Author
|
📝 research notes for future: The problem is with electron, and not with electron-builder. Proof: on macOS, it crashes just the same when you build Suite Desktop from Alternative hypothesis (rejected) was that electron-builder messes up the binary when setting fuses during build. Next steps?
FYI useful for debug: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #16951
It crashes MacOS build, after this revert it works again; need to investigate further 😞
@coderabbitai ignore