Skip to content

Message system - 76 #16688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2025
Merged

Message system - 76 #16688

merged 1 commit into from
Jan 29, 2025

Conversation

MiroslavProchazka
Copy link
Contributor

Adding warning message about sol discovery issues,

Tracked in notion here

@MiroslavProchazka MiroslavProchazka changed the title chore(message-system): add warning message about sol discovery issues" Message system - 76 Jan 28, 2025
@github-actions GitHub Actions
Copy link

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 23
  • More info

Learn more about 𝝠 Expo Github Action

@bosomt
Copy link
Contributor

bosomt commented Jan 29, 2025

QA OK

checked at chore/solana-warning web branch

  • banner is present when SOL is enabled
  • banner is not present when SOL is disabled
  • after you close banner its never shown again after you disable/enable/disable/... SOL
image

Info:

  • Suite version: web 25.2.0 (6caeef4)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1470x956
  • Device: Trezor T3T1 2.8.7 regular (revision 8a254aa8eae82f99630df63f40e4d290066a3efc)
  • Transport: WebUsbTransport

@MiroslavProchazka MiroslavProchazka marked this pull request as ready for review January 29, 2025 07:18
@jvaclavik jvaclavik merged commit 83aabda into develop Jan 29, 2025
36 checks passed
@jvaclavik jvaclavik deleted the chore/solana-warning branch January 29, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvaclavik jvaclavik jvaclavik approved these changes

@tomasklim tomasklim Awaiting requested review from tomasklim tomasklim is a code owner

@matejkriz matejkriz Awaiting requested review from matejkriz matejkriz is a code owner

@Lemonexe Lemonexe Awaiting requested review from Lemonexe

@vytick vytick Awaiting requested review from vytick

@komret komret Awaiting requested review from komret

Assignees
No one assigned
Labels
None yet
Projects
Suite Desktop
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiroslavProchazka @bosomt @jvaclavik