Skip to content

chore(suite-desktop): downgrade electron#15766

Merged
Lemonexe merged 1 commit intodevelopfrom
chore/downgrade-electron
Dec 6, 2024
Merged

chore(suite-desktop): downgrade electron#15766
Lemonexe merged 1 commit intodevelopfrom
chore/downgrade-electron

Conversation

@Lemonexe
Copy link
Copy Markdown
Contributor

@Lemonexe Lemonexe commented Dec 4, 2024

Description

Downgrade electron from 33 to 32.

It shall be kept at 32 until we are ready to cut off macOS Catalina.

ℹ️ electron 32 support
ℹ️ current electron support
ℹ️ systems supported by Suite

@Lemonexe Lemonexe force-pushed the chore/downgrade-electron branch from b395b7d to ffb751e Compare December 4, 2024 12:21
@Lemonexe Lemonexe marked this pull request as ready for review December 4, 2024 12:28
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 4, 2024

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 17
  • More info

Learn more about 𝝠 Expo Github Action

@komret
Copy link
Copy Markdown
Contributor

komret commented Dec 4, 2024

Let's not merge this yet, final decision TBD.

@Lemonexe Lemonexe force-pushed the chore/downgrade-electron branch from ffb751e to a8af3f8 Compare December 6, 2024 10:19
@Lemonexe
Copy link
Copy Markdown
Contributor Author

Lemonexe commented Dec 6, 2024

As discussed on standup, I'll merge this, following implementation of OS analytics in #15789

@Lemonexe Lemonexe merged commit 3bc342a into develop Dec 6, 2024
@Lemonexe Lemonexe deleted the chore/downgrade-electron branch December 6, 2024 10:47
@bosomt
Copy link
Copy Markdown
Contributor

bosomt commented Dec 6, 2024

QA OK

browserName=electron&browserVersion=32.2.6

Info:

  • Suite version: desktop 25.1.0 (5557f53)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/25.1.0 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.6 regular (revision 2625facf1fe9b71db120439853ceca0a61bb8396)
  • Transport: BridgeTransport 2.0.33

@bosomt
Copy link
Copy Markdown
Contributor

bosomt commented Dec 10, 2024

QA OK

electron&browserVersion=32.2.6

Info:

  • Suite version: desktop 24.12.1 (0d4070d)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.12.1 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.6 regular (revision 17f2a3256b2631823c2bad1855fab61b27985fd2)
  • Transport: BridgeTransport 2.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants