Revert "chore(suite-desktop-core): bump openpgp"#15305
Merged
Conversation
This reverts commit a66ece5.
|
🚀 Expo preview is ready!
|
martykan
approved these changes
Nov 7, 2024
Member
martykan
left a comment
martykan
left a comment
There was a problem hiding this comment.
Confirming this seems to fix it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit a66ece5 (downgrades OpenPGP back to 5.11.2)
See slack convo, it broke windows build 😱
This fixes the windows build ✔️
Reason not yet known, but I guess that when they rewritten the library to
mjs, it's not exported as it should, or maybe has hacky code that hardcodes CWD at build time, IDK, I'll have to check.