transport-test: add case for multi devices #14335
Open
+118
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mroz22
commented
Sep 13, 2024
•
mroz22
commented
- 1cb3186
- add support for running a test with multiple connected hw devices at the same time
- 1cb3186
- while I haven't been able to reproduce the behavior reported in Not able to communicate with two devices at once when using node bridge #14285 and this tests seems to be passing quite nicely (local only) I'd say that it already gives us some defensive capabilities regarding future refactorings and fixes, such as NodeBridge + multidevice acquire fix #14339
mroz22
force-pushed
the
transport-multi-devices
branch
6 times, most recently
from
f164f96 to
1cb3186
Compare
mroz22
changed the title
mroz22
force-pushed
the
transport-multi-devices
branch
2 times, most recently
from
30473de to
fa28d0b
Compare
mroz22
force-pushed
the
transport-multi-devices
branch
from
fa28d0b to
31a99f3
Compare
mroz22
commented
Sep 19, 2024
| this.logger.log( | ||
| `${env.USE_HW ? '[MANUAL ACTION REQUIRED] ' : ''} waiting for ${expected} device to be connected`, | ||
| ); | ||
|
|
||
| return scheduleAction( | ||
| async () => { | ||
| const devices = (await webusb.getDevices()).filter(d => d.productName === 'TREZOR'); | ||
| if (devices.length === expected) { | ||
| if (devices.length >= expected) { |
martykan
reviewed
Sep 19, 2024
| @@ -26,6 +26,8 @@ class Controller extends TrezorUserEnvLinkClass { | |||
| private logger: Console; | |||
| private nodeBridge: TrezordNode | undefined = undefined; | |||
|
|
|||
| private expectedNumOfDevices = 0; | |||
There was a problem hiding this comment.
Maybe this should be reset somewhere, when stopEmu is not called it will be incorrect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.