Skip to content

wip: Root package.json dependencies should not be in individual packages #13609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

wip: Root package.json dependencies should not be in individual packages #13609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1c189cc
chore: rimraf only on root package.json
karliatto Aug 2, 2024
1256fef
chore: semver only on root package.json
karliatto Aug 6, 2024
f141d1e
chore: @babel/preset-env only on root package.json
karliatto Aug 6, 2024
a511a94
chore: @babel/preset-react only on root package.json
karliatto Aug 6, 2024
1f15686
chore: @babel/preset-typescript only on root package.json
karliatto Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/address-validator/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
"lodash": "^4.17.15"
},
"devDependencies": {
"jest-environment-jsdom": "29.7.0",
"rimraf": "^6.0.1"
"jest-environment-jsdom": "29.7.0"
}
}
1 change: 0 additions & 1 deletion packages/connect-explorer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@
"copy-webpack-plugin": "^12.0.2",
"eslint-plugin-mdx": "^3.1.5",
"html-webpack-plugin": "^5.6.0",
"rimraf": "^6.0.1",
"tsx": "^4.16.3",
"webpack": "^5.93.0",
"webpack-cli": "^5.1.4"
Expand Down
2 changes: 0 additions & 2 deletions packages/connect-iframe/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,11 @@
"@trezor/connect-common": "workspace:*"
},
"devDependencies": {
"@babel/preset-typescript": "^7.24.7",
"@trezor/env-utils": "workspace:*",
"babel-loader": "^9.1.3",
"copy-webpack-plugin": "^12.0.2",
"es6-promise": "^4.2.8",
"html-webpack-plugin": "^5.6.0",
"rimraf": "^6.0.1",
"terser-webpack-plugin": "^5.3.9",
"webpack": "^5.93.0",
"webpack-cli": "^5.1.4",
Expand Down
3 changes: 0 additions & 3 deletions packages/connect-popup/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@
},
"devDependencies": {
"@babel/plugin-proposal-class-properties": "^7.18.6",
"@babel/preset-react": "^7.24.7",
"@babel/preset-typescript": "^7.24.7",
"@playwright/browser-chromium": "^1.45.3",
"@playwright/browser-firefox": "^1.45.3",
"@playwright/browser-webkit": "^1.45.3",
Expand All @@ -43,7 +41,6 @@
"babel-loader": "^9.1.3",
"copy-webpack-plugin": "^12.0.2",
"html-webpack-plugin": "^5.6.0",
"rimraf": "^6.0.1",
"terser-webpack-plugin": "^5.3.9",
"webpack": "^5.93.0",
"webpack-cli": "^5.1.4",
Expand Down
2 changes: 0 additions & 2 deletions packages/connect-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
"@trezor/utils": "workspace:*"
},
"devDependencies": {
"@babel/preset-typescript": "^7.24.7",
"@playwright/browser-chromium": "^1.45.3",
"@playwright/browser-firefox": "^1.45.3",
"@playwright/browser-webkit": "^1.45.3",
Expand All @@ -57,7 +56,6 @@
"@types/w3c-web-usb": "^1.0.10",
"babel-loader": "^9.1.3",
"html-webpack-plugin": "^5.6.0",
"rimraf": "^6.0.1",
"selfsigned": "^2.4.1",
"terser-webpack-plugin": "^5.3.9",
"tsx": "^4.16.3",
Expand Down
2 changes: 0 additions & 2 deletions packages/connect-webextension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,11 @@
"events": "^3.3.0"
},
"devDependencies": {
"@babel/preset-typescript": "^7.24.7",
"@trezor/node-utils": "workspace:*",
"@trezor/trezor-user-env-link": "workspace:*",
"@types/chrome": "^0.0.269",
"babel-loader": "^9.1.3",
"copy-webpack-plugin": "^12.0.2",
"rimraf": "^6.0.1",
"terser-webpack-plugin": "^5.3.9",
"webpack": "^5.93.0",
"webpack-cli": "^5.1.4",
Expand Down
1 change: 0 additions & 1 deletion packages/connect/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@
"prepublish": "yarn tsx ../../scripts/prepublish.js"
},
"dependencies": {
"@babel/preset-typescript": "^7.24.7",
"@ethereumjs/common": "^4.3.0",
"@ethereumjs/tx": "^5.3.0",
"@fivebinaries/coin-selection": "2.2.1",
Expand Down
1 change: 0 additions & 1 deletion packages/suite-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
"cypress": "^13.6.4",
"cypress-file-upload": "^5.0.8",
"cypress-image-snapshot": "^4.0.1",
"rimraf": "^6.0.1",
"stylelint": "^16.2.1",
"stylelint-config-standard": "^36.0.0",
"tsx": "^4.16.3",
Expand Down
2 changes: 0 additions & 2 deletions packages/suite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@
"redux": "^4.2.1",
"redux-logger": "^3.0.6",
"redux-thunk": "^2.4.2",
"semver": "^7.6.0",
"styled-components": "^6.1.8",
"uuid": "^9.0.1",
"web3-utils": "^4.3.1",
Expand All @@ -134,7 +133,6 @@
"@types/react-window": "^1.8.8",
"@types/redux-logger": "^3.0.11",
"@types/redux-mock-store": "^1.0.6",
"@types/semver": "^7.5.4",
"@types/ua-parser-js": "^0.7.39",
"@types/uuid": "^9.0.6",
"@types/zxcvbn": "^4.4.4",
Expand Down
2 changes: 0 additions & 2 deletions packages/transport/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@
"prepublish": "yarn tsx ../../scripts/prepublish.js"
},
"devDependencies": {
"@babel/preset-env": "^7.23.9",
"@babel/preset-typescript": "^7.24.7",
"@trezor/trezor-user-env-link": "workspace:*",
"@types/bytebuffer": "^5.0.48",
"@types/sharedworker": "^0.0.111",
Expand Down
2 changes: 0 additions & 2 deletions packages/trezor-user-env-link/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,9 @@
"dependencies": {
"@trezor/utils": "workspace:*",
"cross-fetch": "^4.0.0",
"semver": "^7.6.0",
"ws": "^8.18.0"
},
"devDependencies": {
"@types/semver": "^7.5.6",
"@types/ws": "^8.5.5"
}
}
3 changes: 1 addition & 2 deletions suite-common/message-system/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@
"fs-extra": "^11.2.0",
"json-schema-to-typescript": "^13.1.2",
"jws": "^4.0.0",
"proxy-memoize": "2.0.2",
"semver": "^7.6.0"
"proxy-memoize": "2.0.2"
},
"devDependencies": {
"@suite-common/test-utils": "workspace:*",
Expand Down
3 changes: 1 addition & 2 deletions suite-native/device/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
"proxy-memoize": "2.0.2",
"react": "18.2.0",
"react-native": "0.74.1",
"react-redux": "8.0.7",
"semver": "^7.6.0"
"react-redux": "8.0.7"
}
}
23 changes: 1 addition & 22 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8798,7 +8798,6 @@ __metadata:
json-schema-to-typescript: "npm:^13.1.2"
jws: "npm:^4.0.0"
proxy-memoize: "npm:2.0.2"
semver: "npm:^7.6.0"
tsx: "npm:^4.16.3"
languageName: unknown
linkType: soft
Expand Down Expand Up @@ -9390,7 +9389,6 @@ __metadata:
react: "npm:18.2.0"
react-native: "npm:0.74.1"
react-redux: "npm:8.0.7"
semver: "npm:^7.6.0"
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -10488,7 +10486,6 @@ __metadata:
jest-environment-jsdom: "npm:29.7.0"
jssha: "npm:2.3.1"
lodash: "npm:^4.17.15"
rimraf: "npm:^6.0.1"
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -10746,7 +10743,6 @@ __metadata:
redux-thunk: "npm:^2.4.2"
remark-gemoji: "npm:^8.0.0"
remark-gfm: "npm:^4.0.0"
rimraf: "npm:^6.0.1"
styled-components: "npm:^6.1.8"
swr: "npm:^2.2.5"
tsx: "npm:^4.16.3"
Expand All @@ -10759,7 +10755,6 @@ __metadata:
version: 0.0.0-use.local
resolution: "@trezor/connect-iframe@workspace:packages/connect-iframe"
dependencies:
"@babel/preset-typescript": "npm:^7.24.7"
"@trezor/connect": "workspace:*"
"@trezor/connect-analytics": "workspace:*"
"@trezor/connect-common": "workspace:*"
Expand All @@ -10768,7 +10763,6 @@ __metadata:
copy-webpack-plugin: "npm:^12.0.2"
es6-promise: "npm:^4.2.8"
html-webpack-plugin: "npm:^5.6.0"
rimraf: "npm:^6.0.1"
terser-webpack-plugin: "npm:^5.3.9"
webpack: "npm:^5.93.0"
webpack-cli: "npm:^5.1.4"
Expand Down Expand Up @@ -10806,8 +10800,6 @@ __metadata:
resolution: "@trezor/connect-popup@workspace:packages/connect-popup"
dependencies:
"@babel/plugin-proposal-class-properties": "npm:^7.18.6"
"@babel/preset-react": "npm:^7.24.7"
"@babel/preset-typescript": "npm:^7.24.7"
"@playwright/browser-chromium": "npm:^1.45.3"
"@playwright/browser-firefox": "npm:^1.45.3"
"@playwright/browser-webkit": "npm:^1.45.3"
Expand All @@ -10831,7 +10823,6 @@ __metadata:
eth-phishing-detect: "npm:^1.2.0"
html-webpack-plugin: "npm:^5.6.0"
react-dom: "npm:18.2.0"
rimraf: "npm:^6.0.1"
terser-webpack-plugin: "npm:^5.3.9"
webpack: "npm:^5.93.0"
webpack-cli: "npm:^5.1.4"
Expand Down Expand Up @@ -10878,7 +10869,6 @@ __metadata:
version: 0.0.0-use.local
resolution: "@trezor/connect-web@workspace:packages/connect-web"
dependencies:
"@babel/preset-typescript": "npm:^7.24.7"
"@playwright/browser-chromium": "npm:^1.45.3"
"@playwright/browser-firefox": "npm:^1.45.3"
"@playwright/browser-webkit": "npm:^1.45.3"
Expand All @@ -10890,7 +10880,6 @@ __metadata:
"@types/w3c-web-usb": "npm:^1.0.10"
babel-loader: "npm:^9.1.3"
html-webpack-plugin: "npm:^5.6.0"
rimraf: "npm:^6.0.1"
selfsigned: "npm:^2.4.1"
terser-webpack-plugin: "npm:^5.3.9"
tsx: "npm:^4.16.3"
Expand All @@ -10909,7 +10898,6 @@ __metadata:
version: 0.0.0-use.local
resolution: "@trezor/connect-webextension@workspace:packages/connect-webextension"
dependencies:
"@babel/preset-typescript": "npm:^7.24.7"
"@trezor/connect": "workspace:*"
"@trezor/connect-common": "workspace:*"
"@trezor/connect-web": "workspace:*"
Expand All @@ -10920,7 +10908,6 @@ __metadata:
babel-loader: "npm:^9.1.3"
copy-webpack-plugin: "npm:^12.0.2"
events: "npm:^3.3.0"
rimraf: "npm:^6.0.1"
terser-webpack-plugin: "npm:^5.3.9"
webpack: "npm:^5.93.0"
webpack-cli: "npm:^5.1.4"
Expand All @@ -10937,7 +10924,6 @@ __metadata:
version: 0.0.0-use.local
resolution: "@trezor/connect@workspace:packages/connect"
dependencies:
"@babel/preset-typescript": "npm:^7.24.7"
"@ethereumjs/common": "npm:^4.3.0"
"@ethereumjs/tx": "npm:^5.3.0"
"@fivebinaries/coin-selection": "npm:2.2.1"
Expand Down Expand Up @@ -11371,7 +11357,6 @@ __metadata:
react-redux: "npm:8.0.7"
react-router: "npm:^5.2.0"
react-router-dom: "npm:^5.2.0"
rimraf: "npm:^6.0.1"
styled-components: "npm:^6.1.8"
stylelint: "npm:^16.2.1"
stylelint-config-standard: "npm:^36.0.0"
Expand Down Expand Up @@ -11463,7 +11448,6 @@ __metadata:
"@types/react-window": "npm:^1.8.8"
"@types/redux-logger": "npm:^3.0.11"
"@types/redux-mock-store": "npm:^1.0.6"
"@types/semver": "npm:^7.5.4"
"@types/ua-parser-js": "npm:^0.7.39"
"@types/uuid": "npm:^9.0.6"
"@types/zxcvbn": "npm:^4.4.4"
Expand Down Expand Up @@ -11504,7 +11488,6 @@ __metadata:
redux-logger: "npm:^3.0.6"
redux-mock-store: "npm:^1.5.4"
redux-thunk: "npm:^2.4.2"
semver: "npm:^7.6.0"
styled-components: "npm:^6.1.8"
stylelint: "npm:^16.2.1"
stylelint-config-standard: "npm:^36.0.0"
Expand Down Expand Up @@ -11560,8 +11543,6 @@ __metadata:
version: 0.0.0-use.local
resolution: "@trezor/transport@workspace:packages/transport"
dependencies:
"@babel/preset-env": "npm:^7.23.9"
"@babel/preset-typescript": "npm:^7.24.7"
"@trezor/protobuf": "workspace:*"
"@trezor/protocol": "workspace:*"
"@trezor/trezor-user-env-link": "workspace:*"
Expand All @@ -11586,10 +11567,8 @@ __metadata:
resolution: "@trezor/trezor-user-env-link@workspace:packages/trezor-user-env-link"
dependencies:
"@trezor/utils": "workspace:*"
"@types/semver": "npm:^7.5.6"
"@types/ws": "npm:^8.5.5"
cross-fetch: "npm:^4.0.0"
semver: "npm:^7.6.0"
ws: "npm:^8.18.0"
languageName: unknown
linkType: soft
Expand Down Expand Up @@ -12984,7 +12963,7 @@ __metadata:
languageName: node
linkType: hard

"@types/semver@npm:^7.3.12, @types/semver@npm:^7.3.4, @types/semver@npm:^7.5.0, @types/semver@npm:^7.5.4, @types/semver@npm:^7.5.6":
"@types/semver@npm:^7.3.12, @types/semver@npm:^7.3.4, @types/semver@npm:^7.5.0, @types/semver@npm:^7.5.6":
version: 7.5.6
resolution: "@types/semver@npm:7.5.6"
checksum: 10/e77282b17f74354e17e771c0035cccb54b94cc53d0433fa7e9ba9d23fd5d7edcd14b6c8b7327d58bbd89e83b1c5eda71dfe408e06b929007e2b89586e9b63459
Expand Down
Loading