Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(suite): do not use pathname as it includes /web in web version #13409

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix(suite): do not use pathname as it includes /web in web version #13409

merged 1 commit into from
Jul 23, 2024

Conversation

tomasklim
Copy link
Member

Description

  • pathname on root of router object includes /web

Screenshots:

This banner was never visible in web app
Screenshot 2024-07-18 at 9 48 22
and this too
Screenshot 2024-07-18 at 9 48 41

mroz22
mroz22 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@mroz22 mroz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds legit

@tomasklim tomasklim merged commit 4a126f2 into develop Jul 23, 2024
24 checks passed
@tomasklim tomasklim deleted the fix/staking-banner-msg-system-web branch July 23, 2024 11:21
@bosomt
Copy link
Contributor

bosomt commented Jul 23, 2024

QA OK

its visible now

image

Info:

  • Suite version: web 24.8.0 (4a126f2)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2T1 2.7.2 regular (revision da75d8f4b67410b40a9cfd2954d183d81dd6e8e8)
  • Transport: BridgeTransport 2.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroz22 mroz22 mroz22 approved these changes

@MiroslavProchazka MiroslavProchazka MiroslavProchazka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues Suite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tomasklim @bosomt @mroz22 @MiroslavProchazka