chore(suite): accept device update when changed from 'unacquired' to … #13245
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komret
reviewed
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-picking from #13227
you might get into a situation where device becomes unreadable and it can't be communicated with. it simply hangs somewhere in
device.transferOutcall. but since it wasn't unreadable some time ago, it might have been acquired by somebody and never released.This takes you to the screen where you have the "Use device here" button. Clicking the button triggers a connect call, which will fail (something I need yet to solve in #13277) and the device should be changed from unacquired to unreadable.
this was not possible till now as suite would not accept changes of device that do not have features.
discussed briefly with @szymonlesisz, he is ok with this change. May I assign someone, lets say @komret ?