Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(connect): type only exports #13042

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

martykan
Copy link
Member

Description

Enforce type only imports/exports to avoid unneeded schemas getting into bundles

@mroz22
Copy link
Contributor

mroz22 commented Jun 24, 2024

where it was bundled to where we didnt want it to happen? also there is a stupid script that was supposed to catch problems like this. wasn't it enough? https://github.com/trezor/trezor-suite/blob/develop/packages/connect-web/scripts/check-inline-build-size.sh#L9

@martykan
Copy link
Member Author

The inline build is fine due to our tree shaking, but if you import connect-web as a module in some external project and use default webpack settings, you will get a quite big bundle.
This is just some initial exploration on how to improve this, still WIP...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants