-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(lint): improve commit-linting #12200
base: develop
Are you sure you want to change the base?
Conversation
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
9e9b052
to
cd59830
Compare
…-message-linting git-hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @legobeat, sorry, we overlooked this PR, perhaps because it is marked as draft. Looks like a good improvement, but there are some shortcomings. Do you want to get back to it, or should I take it over?
Some issues I noticed:
The git hook does not log the commit hash and message when it fails:
The system dialog window cannot read the colour when using the git hook which results in some gibberish, perhaps the colour can be applied differently or dropped entirely:
Description
lint:commits
package script for independent commit lintingcheck-commit-message.sh
more dynamicLINT_COMMIT_MSG
LINT_COMMITS
check-commit-message.sh
to simplify and avoid future driftRelated Issue
Screenshots:
n/a