chore: pin bn.js version in resolutions#12133
Merged
Conversation
Contributor
|
isnt there something like resolving all the 4.x.x versions to 4.something and all 5.x.x to 5.something? it should be probably safe to merge this if tests pass, but still...
|
Member
Author
|
I checked and it doesn't seem there were breaking changes, maybe one - they made input validation more strict. |
mroz22
approved these changes
Apr 25, 2024
Contributor
mroz22
left a comment
mroz22
left a comment
There was a problem hiding this comment.
lets try, the space safe seems worth it.
Contributor
|
also why do we have solana dep in core.js? this sounds like something that shouldn't be there 
|
Member
Author
|
Seems like it's getting in through blockchain-link solana worker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A lot of dependencies use the
bn.jslibrary, but in different version, resulting in duplicates.I would pin it to the latest version globally.
Screenshots:
For example in Connect core:
Before
After
Final output size is reduced from about 1.5MB to 1.2MB