feat(connect): Cardano message signing #10970
Open
+737
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaskp
force-pushed
the
feat/cardano-message-signing
branch
from
5cf3111 to
b0efb54
Compare
|
The new method should also be added to the |
martykan
reviewed
Feb 1, 2024
| import { hasHexPrefix, isHexString } from '../../../utils/formatUtils'; | ||
|
|
||
| export type CardanoSignMessageParams = { | ||
| signingPath: Path; |
There was a problem hiding this comment.
Small nitpick, but everywhere else we just call this param path
There was a problem hiding this comment.
Originally it was named as such because we supported supplying a different path (then called keyPath) to be used for the address header field instead of address parameters. Then we opted to drop it, but I left the name there in case we ever needed to add the second path back. But I can rename it to path, if you think it would be nicer
mroz22
added
connect
jaskp
force-pushed
the
feat/cardano-message-signing
branch
from
2def0de to
55e4576
Compare
|
Updated with changes to firmware |
jaskp
force-pushed
the
feat/cardano-message-signing
branch
from
a9f474e to
f6ad7dd
Compare
|
Heads-up: I'm going to rebase to fix small conflict with develop |
jaskp
force-pushed
the
feat/cardano-message-signing
branch
from
f6ad7dd to
77cfd51
Compare
|
we need this ASAP for Cardano! |
mroz22
reviewed
Nov 18, 2024
|
|
||
| /** "HelloTrezor!" repeated 86 times (=1032 bytes) in hex */ | ||
| const HELLO_TREZOR_86 = | ||
| '48656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f722148656c6c6f5472657a6f7221'; |
There was a problem hiding this comment.
I wouldn't be offended by something like
'48656c6c6f5472657a6f7221'.repeat(86)
|
Aha, it is still blocked by firmware PR, am I right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for arbitrary message signing as per CIP-8.
https://cips.cardano.org/cip/CIP-0008
trezor/trezor-firmware#3509