Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): separate clear_unused_stack() from sys/linker module #4612

Merged
merged 1 commit into from
Feb 12, 2025
Merged

refactor(core): separate clear_unused_stack() from sys/linker module #4612

merged 1 commit into from
Feb 12, 2025

Conversation

romanz
Copy link
Contributor

@romanz romanz commented Feb 12, 2025

Following #4595 (review).

@romanz romanz self-assigned this Feb 12, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2025 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@romanz romanz force-pushed the romanz/split-stack branch from 092f8f5 to 4ce93be Compare February 12, 2025 09:50
@romanz romanz mentioned this pull request Feb 12, 2025
Draft
@romanz romanz requested a review from cepetr February 12, 2025 10:18
@romanz romanz marked this pull request as ready for review February 12, 2025 10:59
@romanz romanz requested a review from prusnak as a code owner February 12, 2025 10:59
@romanz romanz removed the request for review from prusnak February 12, 2025 10:59
@romanz romanz added the code Code improvements label Feb 12, 2025
cepetr
cepetr approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@cepetr cepetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some tests are failing, but it doesn’t seem to be related to this.

@romanz romanz merged commit ae9e028 into main Feb 12, 2025
162 checks passed
@romanz romanz deleted the romanz/split-stack branch February 12, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cepetr cepetr cepetr approved these changes

Assignees

@romanz romanz

Labels
code Code improvements
Projects
Firmware
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanz @cepetr