Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(core): collect debug logs also from multicore tests #4604

Merged
merged 1 commit into from
Feb 11, 2025
Merged

ci(core): collect debug logs also from multicore tests #4604

merged 1 commit into from
Feb 11, 2025
+30 −17

Conversation

romanz
Copy link
Contributor

@romanz romanz commented Feb 10, 2025 •
edited
Loading

Otherwise, tailing and uploading when running make test_emu_ui_multicore fail:
https://github.com/trezor/trezor-firmware/actions/runs/13049022289/job/36405211984?pr=4558

image

@romanz romanz self-assigned this Feb 10, 2025
@romanz romanz added ci Continuous Integration (CI) related emulator only Issue which does not appear on the physical device - but on emulator only. labels Feb 10, 2025
@romanz romanz force-pushed the romanz/pytest-file-verbose-log branch from e5be75d to 37e9bad Compare February 10, 2025 18:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 10, 2025 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@romanz romanz force-pushed the romanz/pytest-file-verbose-log branch 3 times, most recently from 09b2cb3 to 841002f Compare February 10, 2025 19:58
@romanz romanz changed the title ci(core): allow collecting debug logs also from multicore tests ci(core): collect debug logs also from multicore tests Feb 10, 2025
@romanz
Copy link
Contributor Author

romanz commented Feb 10, 2025

https://github.com/trezor/trezor-firmware/actions/runs/13249341095/artifacts/2567239643

$ unzip -l core-test-device-T2T1-btconly-en-noasan.zip 
Archive:  core-test-device-T2T1-btconly-en-noasan.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
 53122602  2025-02-10 20:10   trezor.log
---------                     -------
 53122602                     1 file

https://github.com/trezor/trezor-firmware/actions/runs/13249341095/artifacts/2567242728

$ unzip -l core-test-device-T2T1-universal-en-noasan.zip 
Archive:  core-test-device-T2T1-universal-en-noasan.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
 19172194  2025-02-10 20:10   trezor-0.log
 20229768  2025-02-10 20:10   trezor-2.log
 33995424  2025-02-10 20:11   trezor-1.log
 16763538  2025-02-10 20:10   trezor-3.log
---------                     -------
 90160924                     4 files

@romanz
Copy link
Contributor Author

romanz commented Feb 10, 2025

Flaky test failure: https://github.com/trezor/trezor-firmware/actions/runs/13249341095/job/36983594451?pr=4604#step:7:1
image

@romanz romanz marked this pull request as ready for review February 10, 2025 20:27
@romanz romanz requested a review from matejcik as a code owner February 10, 2025 20:27
@romanz romanz requested review from mmilata and removed request for matejcik February 10, 2025 20:28
mmilata
mmilata approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@romanz romanz force-pushed the romanz/pytest-file-verbose-log branch from cab818b to 4f74b52 Compare February 11, 2025 05:40
@romanz romanz merged commit 8b12a77 into main Feb 11, 2025
95 checks passed
@romanz romanz deleted the romanz/pytest-file-verbose-log branch February 11, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

Assignees

@romanz romanz

Labels
ci Continuous Integration (CI) related emulator only Issue which does not appear on the physical device - but on emulator only.
Projects
Firmware
Status: 🤝 Needs QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanz @mmilata