Friendlier way to confirm long messages #4601
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies to all:
btc sign-message
,btc verify-message
,ethereum sign-message
,ethereum verify-message
models T, TS3 and TS5.The general idea is: if the message to be signed/verified can fit on 5 pages, we let the user scroll through the whole message. If the message is longer than 5 pages, we let the user confirm the message immediately or scroll through all pages.
Note: the difference between
sign-message
andverify-message
is thatsign-message
uses "hold to confirm". This turned out very complex to achieve on model T in the case of long messages, so we decided to introduce an extra warning screen in that case, to replace the "hold to confirm" (model T, signing long message).