Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendlier way to confirm long messages #4601

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Friendlier way to confirm long messages #4601

wants to merge 3 commits into from

Conversation

ibz
Copy link
Contributor

@ibz ibz commented Feb 10, 2025

This applies to all: btc sign-message, btc verify-message, ethereum sign-message, ethereum verify-message models T, TS3 and TS5.

The general idea is: if the message to be signed/verified can fit on 5 pages, we let the user scroll through the whole message. If the message is longer than 5 pages, we let the user confirm the message immediately or scroll through all pages.

Note: the difference between sign-message and verify-message is that sign-message uses "hold to confirm". This turned out very complex to achieve on model T in the case of long messages, so we decided to introduce an extra warning screen in that case, to replace the "hold to confirm" (model T, signing long message).

@ibz ibz self-assigned this Feb 10, 2025
Copy link

github-actions bot commented Feb 10, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@ibz ibz linked an issue Feb 10, 2025 that may be closed by this pull request
@ibz ibz force-pushed the ibz/long-message branch from 9eaa0ba to c24e0f0 Compare February 10, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 Needs review
Development

Successfully merging this pull request may close these issues.

Cannot Sign Long Messages
1 participant