-
-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): correct Delizia loader completion detection #4598
Open
romanz
wants to merge
1
commit into
main
Choose a base branch
from
romanz/fix-delizia-loader
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue was found while debugging a flaky click test: `tests/click_tests/test_lock.py::test_hold_to_lock` Sample failures: https://github.com/trezor/trezor-firmware/actions/runs/13209659963/job/36880750418 https://github.com/trezor/trezor-firmware/actions/runs/13189762414/job/36820368643 https://github.com/trezor/trezor-firmware/actions/runs/13146713535/job/36686537519 https://github.com/trezor/trezor-firmware/actions/runs/13124809110/job/36619045092 https://github.com/trezor/trezor-firmware/actions/runs/13103415015/job/36554567296 https://github.com/trezor/trezor-firmware/actions/runs/13093382180/job/36532710349 [no changelog]
|
Tested locally on T3T1 emulator:
|
Should I also fix similar
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
core
Trezor Core firmware. Runs on Trezor Model T and T2B1.
emulator only
Issue which does not appear on the physical device - but on emulator only.
T3T1
Trezor Safe 5
tests
Automated integration tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was found while debugging a flaky click test on T3T1 emulator:
tests/click_tests/test_lock.py::test_hold_to_lock
Sample failures:
https://github.com/trezor/trezor-firmware/actions/runs/13209659963/job/36880750418
https://github.com/trezor/trezor-firmware/actions/runs/13189762414/job/36820368643
https://github.com/trezor/trezor-firmware/actions/runs/13146713535/job/36686537519
https://github.com/trezor/trezor-firmware/actions/runs/13124809110/job/36619045092
https://github.com/trezor/trezor-firmware/actions/runs/13103415015/job/36554567296
https://github.com/trezor/trezor-firmware/actions/runs/13093382180/job/36532710349
With the following logging added [1], the test failure seems to happen when the loader detects that it is
ShrunkCompletely
(probably due to animation events timing jitter) and stops the animation:[1] Debug patch