test(core): don't fetch full DebugLinkState by default

[romanz]

In case the main workflow is restarting after a DebugLinkDecision, sending the response of DebugLinkGetState may get interrupted (see #4401).

Let's make the full DebugLinkGetState fetching explicit, to avoid the "restart" race condition.

[github-actions]

core UI changes	device test	click test	persistence test
T2T1 Model T	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
T3B1 Safe 3	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
T3T1 Safe 5	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
All	main(screens)

[matejcik]

no, let's not do that again :( having to propagate return_layout=True everywhere is a major pain and it was super nice to be rid of it after GFL
if we go this route, I'd strongly prefer to never return the layout, and forcing caller to explicitly call read_layout() if they need it.

on a separate note, this breaks the "read text representation of screens" feature. but i don't think anyone is actually using it?

another option is to always return the layout, but make the LayoutContent lazy. you'd have to track both debuglink and wirelink and invalidate the lazy-load -- raise an exception if someone tries to access it after any other messages have been exchanged, because any wirelink traffic can cause the layout to change, so it's no longer the "return value of that particular decision"

[romanz]

if we go this route, I'd strongly prefer to never return the layout, and forcing caller to explicitly call read_layout() if they need it.

Sounds good, I'll change the code to separate sending DebugLinkDecision and fetching the DebugLinkState into separate methods.

this breaks the "read text representation of screens" feature. but i don't think anyone is actually using it?

IIUC, the text representation is collected into tests/ui_tests/reports/test/screen_text.txt when --record-text-layout is specified, e.g.:

pytest -vvv ../tests/device_tests/binance/test_get_address.py --record-text-layout

T3B1_en-device_tests-binance-test_get_address.py::test_binance_get_address[m-44h-714h-0h-0-0-bnb1hgm0p7khfk85zpz-68e2cb5a

T3B1_en-device_tests-binance-test_get_address.py::test_binance_get_address[m-44h-714h-0h-0-1-bnb1egswqkszzfc2uq7-1adfb691

T3B1_en-device_tests-binance-test_get_address.py::test_binance_get_address_chunkify_details[m-44h-714h-0h-0-0-bn-59d4996f
        Account:
        BNB #1
        Derivation path:
        m/44'/714'/0'/0/0
        ********************
        -, -, -
        ////////////////////////////////////////////////////////////////////////////////
        bnb1hgm0p7khfk85zpz5v0j8wnej3a90w709vhkdfu
        ********************
        -, -, -
        ////////////////////////////////////////////////////////////////////////////////

T3B1_en-device_tests-binance-test_get_address.py::test_binance_get_address_chunkify_details[m-44h-714h-0h-0-1-bn-c9025900
        Account:
        BNB #1
        Derivation path:
        m/44'/714'/0'/0/1
        ********************
        -, -, -
        ////////////////////////////////////////////////////////////////////////////////
        bnb1egswqkszzfc2uq78zjslc6u2uky4pw46x4rstd
        ********************
        -, -, -
        ////////////////////////////////////////////////////////////////////////////////

Not sure if there is any other tool that depends on it...

[romanz]

Manually tested on TS5: #4401 (comment)

[romanz]

Thanks! I have squashed, rebased and updated commit description.