-
-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Unchained p2wsh path #4271
Conversation
It is best practice to differentiate the BIP 32 path depending on script type, for example There are two main reasons for this practice, which apply in this case:
Furthermore, I see that you are using the subtree That being said, I think that none of the above is a strict blocker for merging this PR. |
code change ACK. @Shadouts please add a changelog entry. |
Also squash into a single commit and force-push. |
Note that for your own benefit, it would be wise to add a device test to As you are probably aware, this PR does not modify the behavior of Trezor 1 firmware. Again, it's not a requirement from our side, I am only stating this to make sure that it's clear. |
fix: move unchained paths to bitcoin multisig SPENDWITNESS chore: add changelog
62caf4c
to
c3b5dfe
Compare
Changelog added, squashed, and force pushed. |
Unchained plans to support p2wsh using the same
m/45
path we use for p2sh. This change adds theUNCHAINED_
patterns to bitcoinInputScriptType.SPENDP2SHWITNESS
.