Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fit more info into success screen #4023

Merged
merged 5 commits into from
Jul 17, 2024
Merged

fit more info into success screen #4023

merged 5 commits into from
Jul 17, 2024

Conversation

TychoVrahe
Copy link
Contributor

@TychoVrahe TychoVrahe commented Jul 11, 2024 •
edited
Loading

Introduces more sophisticated success animation to fit more info.

Some refactoring was done to frame: mostly i extracted header to separate component to not complicate the frame code with animations. As a side effect, this also safe some flash as the header does not need to be generic. I also extracted the animation from frame to save some more, overall these changes save about 7kB of flash. Some of it is claimed by the animations so net savings about 4kB.

Edit: added one more commit with frame code reshuffling, saving additional ~7kB. 4c23fb8

@TychoVrahe TychoVrahe self-assigned this Jul 11, 2024
@TychoVrahe TychoVrahe requested a review from prusnak as a code owner July 11, 2024 14:45
@TychoVrahe TychoVrahe marked this pull request as draft July 11, 2024 14:45
@TychoVrahe TychoVrahe removed the request for review from prusnak July 11, 2024 14:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 11, 2024 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T2B1 Safe 3 test(screens) main(screens) test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@TychoVrahe TychoVrahe force-pushed the tychovrahe/t3t1/success_anim branch from 9a74353 to 54764b6 Compare July 11, 2024 20:16
@TychoVrahe TychoVrahe marked this pull request as ready for review July 11, 2024 20:53
@Hannsek Hannsek mentioned this pull request Jul 13, 2024
Merged
2 tasks
@Hannsek Hannsek requested review from obrusvit and mmilata July 13, 2024 14:42
@TychoVrahe TychoVrahe force-pushed the tychovrahe/t3t1/success_anim branch from 54764b6 to 4c23fb8 Compare July 15, 2024 07:37
mmilata
mmilata approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

core/translations/en.json Outdated Show resolved Hide resolved
@mmilata mmilata added the translations Put this label on a PR to run tests in all languages label Jul 16, 2024
@TychoVrahe TychoVrahe force-pushed the tychovrahe/t3t1/success_anim branch from 4c23fb8 to 1402912 Compare July 16, 2024 21:22
@TychoVrahe TychoVrahe requested a review from matejcik as a code owner July 17, 2024 05:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

legacy UI changes device test(screens) main(screens)

@TychoVrahe TychoVrahe force-pushed the tychovrahe/t3t1/success_anim branch from 0e89c24 to 38cd130 Compare July 17, 2024 17:31
@TychoVrahe TychoVrahe merged commit 8736581 into main Jul 17, 2024
119 of 120 checks passed
@TychoVrahe TychoVrahe deleted the tychovrahe/t3t1/success_anim branch July 17, 2024 18:23
@bosomt
Copy link

bosomt commented Jul 29, 2024

QA OK

Info:

  • Suite version: desktop 24.7.3 (19fd64f5b2ab1bc265821e34d4c4b9c910864d0e)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.7.3 Chrome/118.0.5993.159 Electron/27.3.8 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.1 regular (revision 008490b)
  • Transport: BridgeTransport 2.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

@obrusvit obrusvit Awaiting requested review from obrusvit

@matejcik matejcik Awaiting requested review from matejcik matejcik is a code owner

Assignees

@TychoVrahe TychoVrahe

Labels
translations Put this label on a PR to run tests in all languages
Projects
Firmware
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TychoVrahe @bosomt @mmilata