Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T3T1 touch tunning #3972

Merged
merged 2 commits into from
Jul 25, 2024
Merged

T3T1 touch tunning #3972

merged 2 commits into from
Jul 25, 2024

Conversation

TychoVrahe
Copy link
Contributor

Two adjustments made to T3T1 touch processing:

  • when missed PRESS_DOWN event and only seeing LIFT_UP, TOUCH_START event is generated to compensate for the missing touch. The missing touches were actually observed on lockscreen's tap to unlock - the animation takes non-trivial amount of time to render so short touches were lost.
  • touch coordinates correction for T3T1 touch panel is introduced. This aims to correct the panel's bias that shifts X coordinate towards center of the panel.

@TychoVrahe TychoVrahe self-assigned this Jun 24, 2024
@TychoVrahe TychoVrahe changed the base branch from main to tychovrahe/ui-t3t1/backlight June 24, 2024 11:07
@TychoVrahe TychoVrahe force-pushed the tychovrahe/ui-t3t1/backlight_with_touch branch from 8b267e1 to 0fd0755 Compare June 24, 2024 11:36
@TychoVrahe TychoVrahe marked this pull request as ready for review June 24, 2024 12:01
@TychoVrahe TychoVrahe requested a review from prusnak as a code owner June 24, 2024 12:01
@TychoVrahe TychoVrahe requested review from cepetr and removed request for prusnak June 24, 2024 12:01
@matejcik matejcik added this to the June release milestone Jun 25, 2024
@TychoVrahe TychoVrahe force-pushed the tychovrahe/ui-t3t1/backlight branch from b630913 to 87aa461 Compare June 26, 2024 10:21
@TychoVrahe TychoVrahe requested a review from matejcik as a code owner June 26, 2024 10:21
@TychoVrahe TychoVrahe force-pushed the tychovrahe/ui-t3t1/backlight branch from 87aa461 to 93df60b Compare June 26, 2024 10:22
@matejcik matejcik removed this from the June release milestone Jun 30, 2024
@matejcik matejcik force-pushed the tychovrahe/ui-t3t1/backlight branch from 93df60b to d1d64f2 Compare June 30, 2024 13:50
cepetr
cepetr reviewed Jun 30, 2024
View reviewed changes
Copy link
Contributor

@cepetr cepetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed changes in the touch driver. It looks good to me, although I haven't tested it.

@TychoVrahe TychoVrahe force-pushed the tychovrahe/ui-t3t1/backlight branch from 6890343 to ae4a8f8 Compare July 1, 2024 06:07
Base automatically changed from tychovrahe/ui-t3t1/backlight to main July 1, 2024 07:33
@TychoVrahe TychoVrahe force-pushed the tychovrahe/ui-t3t1/backlight_with_touch branch from d8da3c8 to f203b09 Compare July 1, 2024 07:55
cepetr
cepetr approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@cepetr cepetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

core/embed/trezorhal/stm32f4/touch/ft6x36.c Show resolved Hide resolved
@TychoVrahe TychoVrahe force-pushed the tychovrahe/ui-t3t1/backlight_with_touch branch from f203b09 to f799e3b Compare July 25, 2024 08:25
@TychoVrahe TychoVrahe merged commit 1212a73 into main Jul 25, 2024
84 checks passed
@TychoVrahe TychoVrahe deleted the tychovrahe/ui-t3t1/backlight_with_touch branch July 25, 2024 09:37
@bosomt
Copy link

bosomt commented Jul 29, 2024

QA OK

Info:

  • Suite version: desktop 24.7.3 (19fd64f5b2ab1bc265821e34d4c4b9c910864d0e)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.7.3 Chrome/118.0.5993.159 Electron/27.3.8 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.1 regular (revision 008490b)
  • Transport: BridgeTransport 2.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cepetr cepetr cepetr approved these changes

@matejcik matejcik Awaiting requested review from matejcik

Assignees

@TychoVrahe TychoVrahe

Labels
None yet
Projects
Firmware
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TychoVrahe @bosomt @cepetr @matejcik