Fix missing confirm_address #3424
Conversation
for now, it catches the following incorrect function:
async def show_foo() -> Awaitable[None]:
return show_something_else("foo")
because to correctly show the result, the caller would have to "await (await show_foo())"
(this should either be "async def show_foo() -> None", or "def show_foo() -> Awaitable[None]")
multiple bugreports complain about poor support for setup.cfg for instance, the load-plugins rule is ignored in setup.cfg
matejcik
force-pushed
the
matejcik/check-async-awaitable
branch
from
ad488d7 to
55a0509
Compare
matejcik
requested review from
mmilata,
grdddj and
andrewkozlik
and removed request for
andrewkozlik
There was a problem hiding this comment.
NIce job!
The pylint worked fine for me locally, even though the speed is disastrous. Did you consider or try creating flake8 plugin? It seems to be much quicker. Unfortunately, ruff still seems not supporting user plugins. (Sure, pylint runs anyway, but it would be nice to get rid of it, so for possible future plugins)
At the first glance, I am not very happy about the different signatures of confirm_address between TR and TT layout code --- was there any reason to not use the second option async def confirm_address() -> None (which should be possible with return await confirm_blob())?
the sync option (
yes, the TT functions should be converted to what TR does, but I didn't want to do that here. (and it might be moot anyway, as we'll soon be able to get rid of those functions)
does it seem to you that it's slower than it was before? pylint is super slow generally but I didn't notice this making it worse |
|
Thanks for the clarifications.
I did not notice any worsening either, so it was a complaint about general |
This PR fixes the problem and adds a lint to check for it in the future.