Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device authentication for Model R #3255

Merged
merged 8 commits into from
Sep 13, 2023

Conversation

andrewkozlik
Copy link
Contributor

No description provided.

@andrewkozlik andrewkozlik self-assigned this Sep 7, 2023
@andrewkozlik andrewkozlik force-pushed the andrewkozlik/authenticate-device branch 2 times, most recently from 211c69f to 6a123ca Compare September 7, 2023 15:46
@andrewkozlik andrewkozlik removed the request for review from prusnak September 7, 2023 15:51
@andrewkozlik
Copy link
Contributor Author

Can we start this review, so that Suite/Connect development can move forward?

common/protob/messages-management.proto Outdated Show resolved Hide resolved
core/embed/trezorhal/optiga/optiga.c Outdated Show resolved Hide resolved
core/embed/trezorhal/optiga/optiga.c Show resolved Hide resolved
core/embed/trezorhal/optiga/optiga.c Outdated Show resolved Hide resolved
core/mocks/generated/trezorutils.pyi Show resolved Hide resolved
core/embed/extmod/modtrezorcrypto/modtrezorcrypto-optiga.h Outdated Show resolved Hide resolved
python/src/trezorlib/cli/device.py Outdated Show resolved Hide resolved
tests/device_tests/test_authenticate_device.py Outdated Show resolved Hide resolved
Copy link
Contributor

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed a commit that adds custom exceptions for Optiga, so that we can better handle the authentication failures

core/embed/extmod/modtrezorcrypto/modtrezorcrypto-optiga.h Outdated Show resolved Hide resolved
core/embed/extmod/modtrezorcrypto/modtrezorcrypto-optiga.h Outdated Show resolved Hide resolved
core/src/apps/management/authenticate_device.py Outdated Show resolved Hide resolved
core/src/apps/management/authenticate_device.py Outdated Show resolved Hide resolved
@andrewkozlik
Copy link
Contributor Author

I am not sure how to deal with this build error correctly:
error: none of the selected packages contains these features: optiga
I assume it comes from the rust build process.

@matejcik
Copy link
Contributor

I am not sure how to deal with this build error correctly: error: none of the selected packages contains these features: optiga I assume it comes from the rust build process.

hopefully like this: 0cc4c01

@andrewkozlik andrewkozlik force-pushed the andrewkozlik/authenticate-device branch from 0cc4c01 to f0cff67 Compare September 13, 2023 12:57
@andrewkozlik andrewkozlik force-pushed the andrewkozlik/authenticate-device branch from f0cff67 to 68e002a Compare September 13, 2023 13:23
@andrewkozlik andrewkozlik merged commit afa6f84 into master Sep 13, 2023
@andrewkozlik andrewkozlik deleted the andrewkozlik/authenticate-device branch September 13, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants