Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update common defs #3216

Merged
merged 4 commits into from
Aug 16, 2023
Merged

chore: update common defs #3216

merged 4 commits into from
Aug 16, 2023

Conversation

szymonlesisz
Copy link
Contributor

@szymonlesisz szymonlesisz commented Aug 15, 2023 •
edited
Loading

Little cleanup in trezor-common definitions:

  • DOGE dust_limit should be set to 0.01 DOGE, not 1 sat below (sending amount below dust is forbidden but sending equal is OK) related to PR in suite also described in DOGE fee policy
  • removed outdated default_fee_b values. i believe they were there because of copy/paste of bitcoin definitions but:
    1. default values are much higher than the reality. long term average for BTG is ~12 for DGB is ~7
    2. multiple fee levels for those coins doesn't make sense since fee estimated by blockbook gives the same value for all of them
  • removed dead blockbooks
    1. I've only tested coins with "support: connect"
    2. Peercoin + PeercoinTestnet is not working either even if they are alive (probably outdated blockbook build or disabled websocket support) so i didn't remove them

@szymonlesisz
fix(common): set DOGE dust_limit to exact value 0.01
f0b80cf
@szymonlesisz
fix(common): BCH, BTG, DGB fix default default_fee_b
d0e0c31 
- removed unnecessary fee levels. estimated values from blockbook for all levels are the same. "Normal" should be enough.
- long term average BTG fee rate is ~12
- long term average DGB fee rate is ~7
@szymonlesisz
chore(common): remove inactive blockbooks
ee8b07d
@szymonlesisz szymonlesisz requested a review from matejcik as a code owner August 15, 2023 16:13
@szymonlesisz szymonlesisz changed the title Szymonlesisz/update common defs chore: update common defs Aug 15, 2023
@prusnak
Copy link
Member

prusnak commented Aug 15, 2023 •
edited
Loading

I added 6926016 which removes MUE coin - it is dead. Please review the added commit.

@prusnak prusnak self-requested a review as a code owner August 15, 2023 20:55
@prusnak
chore(common): remove MUE support
6926016 
the coin is dead, domain not working, etc.
@prusnak prusnak force-pushed the szymonlesisz/update-common-defs branch from db36d09 to 6926016 Compare August 15, 2023 20:56
mroz22
mroz22 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@mroz22 mroz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes make sense to me. but I am not very familiar with this repo so I can' tell if they are complete or something is missing somewhere (eg changelogs,...), so please others review too.

@matejcik matejcik merged commit 92e29b6 into master Aug 16, 2023
@matejcik matejcik deleted the szymonlesisz/update-common-defs branch August 16, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroz22 mroz22 mroz22 approved these changes

@matejcik matejcik Awaiting requested review from matejcik

@prusnak prusnak Awaiting requested review from prusnak

Assignees
No one assigned
Labels
None yet
Projects
Firmware
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szymonlesisz @prusnak @mroz22 @matejcik