Remove FW dumping #2433
Merged
Remove FW dumping #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejcik
force-pushed
the
matejcik/remove-fw-dump
branch
from
16dfb69 to
025768b
Compare
|
The main drawback is that we can no longer test the firmware hashing against the direct dump from device. |
andrewkozlik
approved these changes
Aug 2, 2022
matejcik
force-pushed
the
matejcik/remove-fw-dump
branch
from
77070e0 to
70ce159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverts #2248
We are not going to use this functionality and there is no point in keeping it around.
The feature was never publicly available so the removal should have little impact.