-
-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cardano): add support for babbage features #2354
feat(cardano): add support for babbage features #2354
Conversation
ae2f7f3
to
ae0a111
Compare
are we required to support both? |
The result of internal discussions was that yes, we need to support both, at least for the time being so that wallets and other apps would get a chance to migrate at least. Currently there is however no specific plan to drop the support from our side but it should be doable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With my very limited knowledge about Cardano I have nothing to add that @matejcik didn't already mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @marnova
@gabrielKerekes please squash the fixups so that this is ready to merge
5234172
to
7f82b28
Compare
Done. I also squashed the |
merged via #2355 |
QA OK
https://adastat.net/transactions/735d5f748890d88e9ed60625899e2fc6d336f136a84164de5a9c5aedd6261e7a |
Babbage CDDL
Changes:
collateral_return
- an output which can be added to a transaction to contain unspent collateral. It would only be considered a real tx output if Plutus script validation fails and collateral would be spent. Useful so that any input can be used as collateral.total_collateral
- if the total ADA amount in collateral inputs doesn't match total collateral the transaction is invalid.reference_inputs
- inputs required for script validation.inline_datum
- the whole serialized datum can now be included in the output instead of just the datum hash. Is sent as chunks since it can be quite long. Only first chunk is shown to the user.reference_script
- used for script pre-publishing. Is sent as chunks since it can be quite long. Only first chunk is shown to the user.required_signers
allowed in ORDINARY and MULTISIG txs - there should be no harm in allowing this and some dapps misuse this field fir whatever they need.datum_hash
allowed in non-script outputs - apparently this can be useful to "tag" inputs.