Model R embedded implementation

[TychoVrahe]

Implemented basic Model R functionality:

• display is functional
• buttons are working
• USB comm is working, possible to connect to suite and install (custom) firmware
• shrank loader so it fits the screen, but its not very pretty, probably round loader is not the way
• backlight implemented using display contrast settings, does not work to zero though.
• set colors for monochromatic display in bootloader
• UI needs work, current icons do not fit the display, etc
• using framebuffer in order to support current display functionality used in bootloader, firmware

(firmware is not implemented for R, works partially when fed model type as 'T' via QSTR, but still for example crashes when trying to create wallet, not sure why, maybe missing touch screen causes problems)

Built on top of #2230

[TychoVrahe]

Fixed style issues & force pushed

[TychoVrahe]

Implemented firmware install confirmation via buttons d60ecb2

[matejcik]

please rebase on current master, merging the base branch did something bad to this PR

[matejcik]

fwiw we don't need to check TREZOR_MODEL_1 here because this code will never run as T1 bootloader.

but it's not breaking anything so 🤷‍♀️

[TychoVrahe]

fixed 572cc5b and 2e8dd0f. Though we still have model 1 variant in bootloader SConscript.

However, this breaks the compilation of bootloader for model 1 variant. Since bootloader is part of build_all and build_embed, this also breaks. Which makes me wanna drop the commits. Or i can change these particular conditionals to not throw "Unknown Trezor model" errors.

[matejcik]

can change these particular conditionals to not throw "Unknown Trezor model" errors.

that seems like the best option

[matejcik]

but I'm wondering if we could somehow noop-ize bootloader build for T1. Like, Sconscript.bootloader would just print "not building for T1" instead of doing anything

[TychoVrahe]

This can be achieved with this placed at the beginning of sconscript, seems like a better choice then running dummy compilation:

if TREZOR_MODEL in ('1', ):
    # skip bootloader build
    env = Environment()
    def build_bootloader(target,source,env):
        print(f'Bootloader: nothing to build for Model {TREZOR_MODEL}')
    program_bin = env.Command(
                 target='bootloader.bin',
                 source=None,
                 action=build_bootloader
             )
    Return()

We can include this also in boardloader and bootloader_ci to skip those too.

[TychoVrahe]

fixed 2ba1b65

[TychoVrahe]

rebased onto master & force pushed

[matejcik]

LGTM but I did not review the display driver (display-stm32_R.h) in too much detail.

@hiviah could you please take a look on that part specifically?

[prusnak]

Left couple of questions / suggestions ...

[prusnak]

Now thinking more about changes in display_loader ... I think the better approach is the following:

1. revert changes done to the function
2. rename core/embed/extmod/modtrezorui/loader.h to core/embed/extmod/modtrezorui/loader_T.h
3. set outer = 20 and inner = 14 in core/tools/codegen/gen_loader.py and generate loader_R.h using the modified constants
4. in display.c include either loader_T.hor loader_R.h depending on model
5. update core/embed/extmod/modtrezorui/display.h so it defines LOADER_ICON_SIZE as 24 for Model R (and keep 64 for Model T)

This approach has the following advantages:

• zero changes required to already complicated code in display_loader
• saves some flash space on Model R because the img_loader structure is 9-times smaller
• possibly nicer render of the loader

[TychoVrahe]

Now thinking more about changes in display_loader ... I think the better approach is the following:

Implemented in 55b5a47

The render looks maybe a bit better, but its not a big margin and still likely not good enough for production

[prusnak]

Looks great, thanks!

[hiviah]

LGTM, looked at the display driver more in detail, looks sane, though I couldn't test it on HW.

[matejcik]

@TychoVrahe please squash, rebase, fix style checks etc.

[matejcik]

please add a changelog entry, something like Added: basic Trezor Model R hardware support.
(see misc/changelog.md for instructions)

[TychoVrahe]

Added changelog entries, squashed (still some separate commits that make sense to me, let me know if further squashing is required), force pushed.

[matejcik]

T1 core build is now broken, please fix

[TychoVrahe]

T1 core build is now broken, please fix

fixed in 718be20

[matejcik]

everything seems to pass now so please squash the last fixup and let's get this merged

[TychoVrahe]

squashed

[matejcik]

🎉