implement exception handling for Rust #1811
Conversation
| KeyError(Obj), | ||
| AttributeError(Qstr), | ||
| ValueError(&'static CStr), | ||
| ValueErrorParam(&'static CStr, Obj), | ||
| } |
There was a problem hiding this comment.
It's a bit unfortunate that this ties the Error type to MicroPython, and pollutes all the modules with it, but I suppose that a single error type is a bit of a (very convenient) anti-pattern anyway.
There was a problem hiding this comment.
true, but it turns out that we don't do basically any error handling within Rust and the Error type is almost always supposed to fall through to uPy
matejcik
force-pushed
the
matejcik/rust-exceptions
branch
2 times, most recently
from
ba2d12c to
5c09fe5
Compare
matejcik
force-pushed
the
matejcik/rust-exceptions
branch
from
a4640be to
63b7936
Compare
chore(core): Add test for Rust exc catching chore(core): Document exception catching in Rust [no changelog]
[no changelog]
[no changelog]
[no changelog]
exclude the None value, because prev_hash is now required on protobuf level unify the parametrization across tests
matejcik
force-pushed
the
matejcik/rust-exceptions
branch
from
63b7936 to
036d489
Compare
|
Builds are failing because in micropython 1.17 the function |
|
i'll probably hand-call it where needed |
|
it seems that the Rust unit tests are now broken because symbols are missing: |
|
My understanding of the problem: previously we did not call any uPy code from unit tests but now we do so we need to link uPy objects to the test binary. I think we need to call
|
|
The |
|
Nice, I forgot that the UI branch already had this using |
fixes #1598