Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drbg rework (part 1) #1554

Merged
merged 4 commits into from
May 21, 2021
Merged

Drbg rework (part 1) #1554

merged 4 commits into from
May 21, 2021

Conversation

onvej-sl
Copy link
Contributor

This PR replaces #1481.

The purpose of this PR is to replace hmac_drbg (that is used by random interrupts and wait_random) with faster chacha_drbg.

@onvej-sl onvej-sl requested review from hiviah and andrewkozlik March 29, 2021 11:37
@onvej-sl onvej-sl requested a review from prusnak as a code owner March 29, 2021 11:37
@onvej-sl onvej-sl removed the request for review from prusnak March 29, 2021 11:38
@onvej-sl
Copy link
Contributor Author

onvej-sl commented Mar 29, 2021

These are comments unresolved in the original PR that are related to this PR:
#1481 (comment)
#1481 (comment)
#1481 (comment)

Copy link
Contributor

@andrewkozlik andrewkozlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still doesn't make sense to me why the original pull request was closed after having been extensively reviewed. I had to redo this entire review from scratch and there is more to come. Terribly inefficient.

legacy/random_delays.h Outdated Show resolved Hide resolved
core/embed/trezorhal/random_delays.c Outdated Show resolved Hide resolved
core/embed/trezorhal/random_delays.c Show resolved Hide resolved
core/embed/trezorhal/random_delays.c Show resolved Hide resolved
@onvej-sl onvej-sl requested a review from andrewkozlik May 5, 2021 12:23
@tsusanka tsusanka added this to the 21.06 milestone May 20, 2021
@onvej-sl onvej-sl force-pushed the onvej-sl/drbg_rework_1 branch from d1164f4 to bf018cb Compare May 20, 2021 12:58
@onvej-sl onvej-sl merged commit 6fd4739 into master May 21, 2021
@onvej-sl onvej-sl deleted the onvej-sl/drbg_rework_1 branch May 21, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants