This repository has been archived by the owner on Nov 16, 2021. It is now read-only.
ed25519: scalarmult fix so dst can be src #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ge25519_scalarmult
minor changes:r
can be equal to the inputp1
(same point pointer).T
coordinate), not the partial.ge25519_scalarmult_base_niels
already returns full point so it would make it more consistentcurve25519_mul
, typically(64*const)
, one more before returning from the function is IMO small overhead.ge25519_scalarmult
returns partial point one cannot easily make it full point because afterge25519_scalarmult
returns, the temporary point is not not accessible. To make it full point much more expensive inversion would be needed.