-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support extendable backup flag #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functionality LGTM.
i added a bunch of commits fixing tiny problems. please review 706934d in particular which is the only questionable one -- it seemed cleaner to pass the full customization string into RS1024 from the outside. but I'm not attached to that solution, i'll remove that commit if you dislike it.
a1cb726 Updated a comment. The customization string |
706934d breaks generate_vectors.py, line 66: mnemonic = wordlist.mnemonic_from_indices(
indices + rs1024.create_checksum(indices, False)
) |
LGTM, go ahead |
Related to spec update satoshilabs/slips#1724.
Note that we need to get this merged and released in order for the firmware device tests to pass on the corresponding firmware branch https://github.com/trezor/trezor-firmware/compare/andrewkozlik/slip39.