Add Arbitrum One and Arbitrum Nova Support #1112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaladinlight
commented
Jul 15, 2024
| @@ -1,6 +1,7 @@ | |||
| BIN_IMAGE = blockbook-build | |||
| DEB_IMAGE = blockbook-build-deb | |||
| PACKAGER = $(shell id -u):$(shell id -g) | |||
| DOCKER_VERSION = $(shell docker version --format '{{.Client.Version}}') | |||
There was a problem hiding this comment.
Use the same docker version installed on host machine for deb image for safety
kaladinlight
commented
Jul 15, 2024
| @@ -27,7 +28,7 @@ test-all: .bin-image | |||
| docker run -t --rm -e PACKAGER=$(PACKAGER) -v "$(CURDIR):/src" --network="host" $(BIN_IMAGE) make test-all ARGS="$(ARGS)" | |||
|
|
|||
| deb-backend-%: .deb-image | |||
| docker run -t --rm -e PACKAGER=$(PACKAGER) -v "$(CURDIR):/src" -v "$(CURDIR)/build:/out" $(DEB_IMAGE) /build/build-deb.sh backend $* $(ARGS) | |||
| docker run -t --rm -e PACKAGER=$(PACKAGER) -v /var/run/docker.sock:/var/run/docker.sock -v "$(CURDIR):/src" -v "$(CURDIR)/build:/out" $(DEB_IMAGE) /build/build-deb.sh backend $* $(ARGS) | |||
There was a problem hiding this comment.
Mount docker socket to enable the ability to pull docker images from inside a docker container
kaladinlight
commented
Jul 15, 2024
| @@ -9,6 +9,16 @@ RUN apt-get update && \ | |||
| apt-get install -y devscripts debhelper make dh-exec zstd && \ | |||
| apt-get clean | |||
|
|
|||
| # install docker cli | |||
There was a problem hiding this comment.
Install docker cli to enable binary via docker image
kaladinlight
commented
Jul 15, 2024
| docker container inspect extract > /dev/null 2>&1 && docker rm extract || true | ||
| docker create --name extract {{.Backend.DockerImage}} | ||
| {{- if eq .Backend.VerificationType "docker"}} | ||
| [ "$$(docker inspect --format='{{`{{index .RepoDigests 0}}`}}' {{.Backend.DockerImage}} | sed 's/.*@sha256://')" = "{{.Backend.VerificationSource}}" ] |
There was a problem hiding this comment.
docker verification type will validate the hash of the specified docker image
kaladinlight
commented
Jul 15, 2024
| mkdir backend | ||
| {{- if ne .Backend.DockerImage "" }} | ||
| docker container inspect extract > /dev/null 2>&1 && docker rm extract || true | ||
| docker create --name extract {{.Backend.DockerImage}} |
There was a problem hiding this comment.
create docker extraction image to allow copying of pre-built contents directly from the official docker image
kaladinlight
commented
Jul 15, 2024
| "docker_image": "offchainlabs/nitro-node:v3.0.3-3ecd01e", | ||
| "verification_type": "docker", | ||
| "verification_source": "6bfb702e99d66db88658e712ed0d8691abe03797afe436eaab60a6f31e627e0d", | ||
| "extract_command": "docker cp extract:/home/user/target backend/target; docker cp extract:/home/user/nitro-legacy backend/nitro-legacy; docker cp extract:/usr/local/bin/nitro backend/nitro", |
There was a problem hiding this comment.
example of docker extract command. copy the nitro binary and associated wasm modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for Arbitrum One and Arbitrum Nova (default and archive versions) and also brings in the ability to use official docker images as a means of acquiring pre-built binaries and associated runtime requirements.
The raitionale here is that most blockchains support official docker images as a first class citizen and this handles all build environment reqs. In the case of arbitrum's nitro node, there was requirement for node + yarn + docker + rust + go among others which was way too much to manage for build from source (https://docs.arbitrum.io/run-arbitrum-node/nitro/build-nitro-locally). There was also no directly provided pre-build binary to leverage.
This seemed safe to me considering docker is already a requirement of blockbook and therefore doesn't add any extra reqs for docker in docker use. It will also make the backend definition requirements much easier where we can just grab the binary from the docker file and call it a day.
Hopefully this change seems reasonable and sane to you. Happy to discuss further. Thanks!