import transaction comments from ledger #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the changes simply rename 'V8' column to 'comment', and allow this column to be selected.
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
+ Coverage 93.42% 94.73% +1.31%
==========================================
Files 2 2
Lines 152 152
==========================================
+ Hits 142 144 +2
+ Misses 10 8 -2
Continue to review full report at Codecov.
|
trevorld
added a commit
that referenced
this pull request
Nov 16, 2018
|
Jenya, thanks for the PR! Do you happen to know what the second column (V2) is supposed to contain? It and the comment field (V8) were always all missing values for the test ledger files I read in and the ledger csv output lacks a header. |
|
the V2 column is also a mystery to me... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the changes simply rename 'V8' column to 'comment', and allow this
column to be selected.