Skip to content

Commit

Permalink
use type reference on zone.js
Browse files Browse the repository at this point in the history
This avoids needing the "files" reference to zone.js.d.ts, which could
break if the hoisting of the "zone.js" changes in the installation.

Refs: open-telemetry/opentelemetry-js#4257
  • Loading branch information
trentm committed Nov 8, 2023
1 parent 0f026d0 commit faed214
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"outDir": "build/esm",
"tsBuildInfoFile": "build/esm/tsconfig.esm.tsbuildinfo"
},
"files": [ "../../../node_modules/zone.js/dist/zone.js.d.ts"],
"include": [
"src/**/*.ts"
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
* limitations under the License.
*/

/// <reference types="zone.js" />

import { isWrapped, InstrumentationBase } from '@opentelemetry/instrumentation';

import * as api from '@opentelemetry/api';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"skipLibCheck": true,
"tsBuildInfoFile": "build/esm/tsconfig.esm.tsbuildinfo"
},
"files": [ "../../../node_modules/zone.js/dist/zone.js.d.ts"],
"include": [
"src/**/*.ts"
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"outDir": "build",
"skipLibCheck": true
},
"files": [ "../../../node_modules/zone.js/dist/zone.js.d.ts"],
"include": [
"src/**/*.ts",
"test/**/*.ts"
Expand Down

0 comments on commit faed214

Please sign in to comment.