Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SSR): change the unreliable pseudo class ":first-child" to ":first-of-type" #253

Merged
merged 15 commits into from
Nov 6, 2020
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-styled-ui/src/Checkbox/styles.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ const interactionProps = ({ color, colorMode }) => {
bg: 'inherit',
borderColor: checkedAndFocusBorderColor,
color: checkedAndFocusColor, // Icon color
'& > :first-child': {
'& > div:first-of-type': {
bg: checkedAndFocusBgColor,
},
},
Expand Down
19 changes: 7 additions & 12 deletions packages/react-styled-ui/src/Drawer/DrawerBody.js
Original file line number Diff line number Diff line change
@@ -1,20 +1,15 @@
import React, { forwardRef } from 'react';
import Box from '../Box';
import PseudoBox from '../PseudoBox';
import {
useDrawerBodyStyle,
} from './styles';

const DrawerBody = forwardRef((props, ref) => {
const styleProps = useDrawerBodyStyle();
return (
<Box
<PseudoBox
ref={ref}
px="6x"
pb="6x"
flex="1"
h="auto"
overflowY="auto"
css={{
'&:first-child': {
marginTop: (16 + 28 + 12),
},
}}
{...styleProps}
{...props}
/>
);
Expand Down
4 changes: 2 additions & 2 deletions packages/react-styled-ui/src/Drawer/DrawerContent.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import Icon from '../Icon';
import useForkRef from '../utils/useForkRef';
import { useDrawer } from './context';
import {
useDrawerContentStyles,
useDrawerContentStyle,
useDrawerCloseButtonStyle,
} from './styles';

Expand Down Expand Up @@ -62,7 +62,7 @@ const DrawerContentFront = forwardRef(({ children, ...props }, ref) => {
contentRef,
} = { ...context };
const combinedRef = useForkRef(ref, contentRef);
const contentStyleProps = useDrawerContentStyles({ placement, size });
const contentStyleProps = useDrawerContentStyle({ placement, size });

return (
<Box
Expand Down
26 changes: 7 additions & 19 deletions packages/react-styled-ui/src/Drawer/DrawerFooter.js
Original file line number Diff line number Diff line change
@@ -1,27 +1,15 @@
import React, { forwardRef } from 'react';
import Flex from '../Flex';
import useColorMode from '../useColorMode';
import PseudoBox from '../PseudoBox';
import {
useDrawerFooterStyle,
} from './styles';

const DrawerFooter = forwardRef((props, ref) => {
const { colorMode } = useColorMode();
const borderColor = {
dark: 'gray:80',
light: 'gray:20', // TBD: light mode is not ready yet
}[colorMode];

const styleProps = useDrawerFooterStyle();
return (
<Flex
<PseudoBox
ref={ref}
justify="flex-end"
px="6x"
py="4x"
borderTop={1}
borderTopColor={borderColor}
css={{
'&:first-child': {
marginTop: (16 + 28 + 12),
},
}}
{...styleProps}
{...props}
/>
);
Expand Down
17 changes: 8 additions & 9 deletions packages/react-styled-ui/src/Drawer/DrawerHeader.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
import React, { forwardRef } from 'react';
import Box from '../Box';
import PseudoBox from '../PseudoBox';
import {
useDrawerHeaderStyle,
} from './styles';

const DrawerHeader = forwardRef((props, ref) => {
const styleProps = useDrawerHeaderStyle();

return (
<Box
<PseudoBox
ref={ref}
pt="4x"
pb="3x"
pl="6x"
pr="12x"
position="relative"
fontSize="xl"
lineHeight="xl"
{...styleProps}
{...props}
/>
);
Expand Down
59 changes: 55 additions & 4 deletions packages/react-styled-ui/src/Drawer/styles.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ const useDrawerCloseButtonStyle = () => {
};
};

const useDrawerContentStyles = ({
const useDrawerContentStyle = ({
placement,
size,
}) => {
Expand All @@ -110,7 +110,7 @@ const useDrawerContentStyles = ({
display: 'flex',
flexDirection: 'column',
};
const colorModeStyles = {
const colorModeStyle = {
light: {
color: 'black:primary',
bg: 'white',
Expand All @@ -133,13 +133,64 @@ const useDrawerContentStyles = ({

return {
...baseStyle,
...colorModeStyles,
...colorModeStyle,
...placementProps,
...sizeProps,
};
};

const useDrawerHeaderStyle = () => {
return {
pt: '4x',
pb: '3x',
pl: '6x',
pr: '12x',
position: 'relative',
fontSize: 'xl',
lineHeight: 'xl',
};
};

const useDrawerBodyStyle = () => {
const { sizes, lineHeights } = useTheme();

return {
px: '6x',
pb: '6x',
flex: 1,
height: 'auto',
overflowY: 'auto',
_firstOfType: {
marginTop: `calc(${get(sizes, '4x')} + ${get(lineHeights, 'xl')} + ${get(sizes, '3x')})`,
},
};
};

const useDrawerFooterStyle = () => {
const { colorMode } = useColorMode();
const { sizes, lineHeights } = useTheme();
const borderColor = {
dark: 'gray:80',
light: 'gray:20', // TBD: light mode is not ready yet
}[colorMode];

return {
display: 'flex',
justifyContent: 'flex-end',
px: '6x',
py: '4x',
borderTop: 1,
borderTopColor: borderColor,
_firstOfType: {
marginTop: `calc(${get(sizes, '4x')} + ${get(lineHeights, 'xl')} + ${get(sizes, '3x')})`,
},
};
};

export {
useDrawerCloseButtonStyle,
useDrawerContentStyles,
useDrawerContentStyle,
useDrawerHeaderStyle,
useDrawerBodyStyle,
useDrawerFooterStyle,
};
2 changes: 1 addition & 1 deletion packages/react-styled-ui/src/Input/styles.js
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ const getInputGroupCSS = ({
const useNegativeMargin = (variant === 'outline' || variant === 'filled');

return {
'&:not(:first-child)': {
'&:not(:first-of-type)': {
borderTopLeftRadius: 0,
borderBottomLeftRadius: 0,
},
Expand Down
4 changes: 2 additions & 2 deletions packages/react-styled-ui/src/InputGroupAppend/styles.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ const notLastChildStyle = {
const baseProps = {
ml: -1,
css: {
'& > *:first-child': notFirstChildStyle,
'&:not(:last-child) > *:first-child': notLastChildStyle,
'& > *:first-of-type': notFirstChildStyle,
'&:not(:last-child) > *:first-of-type': notLastChildStyle,
}
};

Expand Down
4 changes: 2 additions & 2 deletions packages/react-styled-ui/src/InputGroupPrepend/styles.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ const notLastChildStyle = {
const baseProps = {
mr: -1,
css: {
'& > *:first-child': notLastChildStyle,
'&:not(:first-child) > *:first-child': notFirstChildStyle,
'& > *:first-of-type': notLastChildStyle,
'&:not(:first-of-type) > *:first-of-type': notFirstChildStyle,
},
};

Expand Down
20 changes: 8 additions & 12 deletions packages/react-styled-ui/src/Modal/ModalBody.js
Original file line number Diff line number Diff line change
@@ -1,20 +1,16 @@
import React, { forwardRef } from 'react';
import Box from '../Box';
import PseudoBox from '../PseudoBox';
import {
useModalBodyStyle,
} from './styles';

const ModalBody = forwardRef((props, ref) => {
const styleProps = useModalBodyStyle();

return (
<Box
<PseudoBox
ref={ref}
px="6x"
pb="6x"
flex="1"
h="auto"
overflowY="auto"
css={{
'&:first-child': {
marginTop: (16 + 28 + 12),
},
}}
{...styleProps}
{...props}
/>
);
Expand Down
4 changes: 2 additions & 2 deletions packages/react-styled-ui/src/Modal/ModalContent.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import Icon from '../Icon';
import useForkRef from '../utils/useForkRef';
import { useModal } from './context';
import {
useModalContentStyles,
useModalContentStyle,
useModalCloseButtonStyle,
} from './styles';

Expand Down Expand Up @@ -61,7 +61,7 @@ const ModalContentFront = forwardRef(({ children, ...props }, ref) => {
contentRef,
} = { ...context };
const combinedRef = useForkRef(ref, contentRef);
const contentStyleProps = useModalContentStyles({ size });
const contentStyleProps = useModalContentStyle({ size });

return (
<Box
Expand Down
25 changes: 7 additions & 18 deletions packages/react-styled-ui/src/Modal/ModalFooter.js
Original file line number Diff line number Diff line change
@@ -1,27 +1,16 @@
import React, { forwardRef } from 'react';
import Flex from '../Flex';
import useColorMode from '../useColorMode';
import PseudoBox from '../PseudoBox';
import {
useModalFooterStyle,
} from './styles';

const ModalFooter = forwardRef((props, ref) => {
const { colorMode } = useColorMode();
const borderColor = {
dark: 'gray:80',
light: 'gray:20', // TBD: light mode is not ready yet
}[colorMode];
const styleProps = useModalFooterStyle();

return (
<Flex
<PseudoBox
ref={ref}
justify="flex-end"
px="6x"
py="4x"
borderTop={1}
borderTopColor={borderColor}
css={{
'&:first-child': {
marginTop: (16 + 28 + 12),
},
}}
{...styleProps}
{...props}
/>
);
Expand Down
17 changes: 8 additions & 9 deletions packages/react-styled-ui/src/Modal/ModalHeader.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
import React, { forwardRef } from 'react';
import Box from '../Box';
import PseudoBox from '../PseudoBox';
import {
useModalHeaderStyle,
} from './styles';

const ModalHeader = forwardRef((props, ref) => {
const styleProps = useModalHeaderStyle();

return (
<Box
<PseudoBox
ref={ref}
pt="4x"
pb="3x"
pl="6x"
pr="12x"
position="relative"
fontSize="xl"
lineHeight="xl"
{...styleProps}
{...props}
/>
);
Expand Down
Loading