Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tooltip Overlapping Charts due to a low z-index #1087

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Sho-ki
Copy link

@Sho-ki Sho-ki commented Jun 17, 2024

Description
This pull request addresses the issue where the tooltip overlaps surrounding charts due to a low z-index. The fix ensures that the tooltip has a higher z-index, preventing it from overlapping the charts and improving the overall user experience.

Related issue(s)
Fixes #1066

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • New Feature (BREAKING CHANGE which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has this been tested?

  • Manually tested the tooltip functionality across different browsers and screen sizes.
  • Verified that the tooltip no longer overlaps with surrounding charts.
  • Ensured that other elements' z-index are not adversely affected.

Screenshots (if appropriate):
Before:
image

After:
Screen Shot 2024-06-16 at 17 52 18

The PR fulfils these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 5:37am

@Sho-ki Sho-ki changed the title Fix: Tooltip Overlapping Charts due to a low z-index fix: Tooltip Overlapping Charts due to a low z-index Jun 17, 2024
Copy link

@alexbalonperin alexbalonperin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you could apply this fix to all chart types (e.g. LineChart, AreaChart, etc). 🙂

@Sho-ki
Copy link
Author

Sho-ki commented Jun 21, 2024

Sure, I'll be working on it.

@Sho-ki
Copy link
Author

Sho-ki commented Jun 27, 2024

I've fixed other chart types as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: When Tooltip overlaps on surrounding charts, the zindex seems to be too low
2 participants